Add unit tests (that GitHub will auto-trigger when pushing new code) about ips-comment-bot HOT 7 CLOSED

Yes, definitely. This would be a good thing, however I think it might require changes to some dependencies (i.e. ChatX, SE::API). It'd be a big project, although it would be useful.

from ips-comment-bot.

@thesecretmaster

So I actually got kinda fired up about this this weekend and started on a major refactor that would isolate the dependencies to make it easy to make mock classes. I also set things up to use a test_db for when the unit-tests get run (that'll get wiped before/after every test module).

I pushed it up in the unit-test branch.

As this is a friggin massive overhaul, I think it'd probably be a good idea if you took a look at it to give me the greenlight that I'm on the right track, before I put more work into it and end up having to scrap everything.

From here I'll probably continue much the same with a wrapper for handling chat replies and then another for the SE client.

Let me know what you think when you get the chance.

(Also I decided to try out Sublime as an IDE for the first time and realized right after I pushed that it'd been sticking in tabs instead of spaces the whole time. I'll fix that on the next commit--please forgive me 😭)

from ips-comment-bot.

Couple of things: Firstly, delete code instead of commenting it -- it's all stored in the git history, we don't need it anymore. Second, you don't need a main function. Just put it in the top level scope. Third, is this tested? Do you know it all runs fine? (this is just initial thoughts, I haven't really reviewed the substance yet)

from ips-comment-bot.

Also, can you make it a PR? I need it to be a PR so I can actually leave comments, otherwise github won't let me.

from ips-comment-bot.

Firstly. Good call. I guess old habits die hard. I've been cleaning it up as I recreate it, but I'll kill it all on my next commit.

Secondly, old habits die hard pt. II, I'll take it out.

Thirdly, I've been testing as I'm going by hand, but I'm also slowly adding tests too. By the time I finish I should have basic tests for most of it. (But suffice to say it is functional--or what I've made so far is).

Lastly, I was holding out until I had a fully working version to make a pull request (which should be the end of this weekend). But I'll put this up now and then just keep contributing to it as I go, good call.

from ips-comment-bot.

The big refactor is here!! Merged into master as of 147fa43

from ips-comment-bot.

Github auto-triggers test runs on push as of be23595!!

from ips-comment-bot.