fix: import public causes AssertionError about protoc-gen-ts HOT 7 CLOSED

Hey. Thank you for reporting this.

I will try to take a look this week.

from protoc-gen-ts.

Also seen as: protocolbuffers/protobuf-javascript#55 in js version. This is something that we definitely have to solve here.

from protoc-gen-ts.

Update;

Upon closer look, I realized that public import directive transitively re-exports the symbols from dependencies. When you have two public imports with same package name they will conflict and lead to compiler errors.

TLDR: It is not so easy to solve this problem of re-exporting transitive dependencies.

// old.proto
syntax = "proto3";

import public "public.proto";
import public "public2.proto";

message OldMarker {
    importdirective.PublicMessage pubMessageField = 4;
    importdirective.PublicMessage2 pubMessageField2 = 5;
}

// public.proto
syntax = "proto3";

package importdirective;


message PublicMessage {
    bool pb = 1;
}

// public2.proto
syntax = "proto3";

package importdirective;

message PublicMessage2 {
    bool pb = 1;
}

this will lead to export conflicts. in order to work around this, we need to explicitly import symbols from transitive dependencies and re-export the symbols from them within a namespace whose name is identical to conflicting packages.

this is what the protoc compiler wants us to do. merge everything under a namespace if the protos has the same package directive hence it is safe to do because protoc guarantees that there can not be identically named symbols under the same name

from protoc-gen-ts.

But still, there are more cursed cases;

syntax = "proto3";

package importdirective;

import public "test/import/public.proto";
import public "test/import/public2.proto";

message OldMarker {
    importdirective.PublicMessage pubMessageField = 4;
    importdirective.PublicMessage2 pubMessageField2 = 5;
}

where we need to re-export everything that conflicts as well as the symbols in the proto within the same package.

from protoc-gen-ts.

@thesayyn Quite the can of worms indeed. :-) Thank you again for the investigation/fix efforts!

from protoc-gen-ts.

I am going to close this as not planned.

from protoc-gen-ts.

@thesayyn Cool, thanks for the update! Hopefully the upstream repo adds support to it at some point.

from protoc-gen-ts.