Finish oneof support about protoc-gen-ts HOT 4 CLOSED

P.S. if it is any help, if you'd write a "pseudo code" commit adding this functionality, I could complete that. Not sure if it would save you time, but wanted to offer :)

from protoc-gen-ts.

Hey, thank you for opening this. We had a brief conversation on another issue.

It makes more sense to continue the conversation here.

P.S. if it is any help, if you'd write a "pseudo code" commit adding this functionality, I could complete that. Not sure if it would save you time, but wanted to offer :)

I can assist you on the way if you could open up a draft pull request.

from protoc-gen-ts.

Hey @melonmouse

When you have some time, could you join the discussion at #39 about one-of-fields?

@melonmouse I have sent PR for this feature on #53

from protoc-gen-ts.

Sahin, sorry to be late getting to this, I've been off for the summer.
It seems that this needs a bit more work; consider:

message TypedMsg {
  oneof value {
    bool boolValue = 3;
    int32 intValue = 4;
    string strValue = 5;
  }
}

I believe it should be the case that:

let msgInt = new TypedMsg({intValue: 23})
let msgStr = new TypedMsg(strValue: "foo"})
assert( msgInt.intValue === 23)      // works
assert( msgStr.strValue === "foo")   // works
assert( msgInt.value === 23)         // fails: msgInt.value === "intValue"
assert( msgStr.value === "foo")      // fails: msgStr.value === "strValue"

The type of TypedValue.value should be: number | string | boolean | void [or | undefined? i'm not an expert on that ]
rather than: "intValue" | "strValue" | "boolValue" | "none"

from protoc-gen-ts.