fromObject(toObject()) is not working correctly for oneof fields about protoc-gen-ts HOT 2 CLOSED

+1 it looks like the 'return defaults' in toObject will always add every field defined as 'oneof', as a result if you try to quickly clone an instance of a message with you'll drop the contents of the oneof fields, and only keep the one numerically last in the proto spec:

e.g.

message Example { oneof value { int64 int_value = 1; double double_value = 2; } }

const objectOne = new Example({ int_value: 1 })
const objectOneTO = objectOne.toObject()
const objectTwo = Example.fromObject(objectOneTO)
// objectTwo.value === "double_value", int_value has vanished

I think a reasonable fix is that instead of this condition:

We need to lookup the current result of computeOneofCase and include that field and only that field (with default through the corresponding field's getter) in toObject.

from protoc-gen-ts.

This is fixed with the rust rewrite. Now we conform to protobuf json encoding.

from protoc-gen-ts.