Make generated Typescript outputs compatible with Typescript strict mode about protoc-gen-ts HOT 4 CLOSED

@NfNitLoop yes that would be great. Also, a clear description of the problem would make it easier for me to solve.

from protoc-gen-ts.

Just adding some extra detail to this ticket for why strict mode is important.

Currently if you have a proto like:

message Example {
    oneof foo_or_bar {
        Foo foo = 1;
        Bar bar = 2;
    }
}

then the Example type will get generated with:

get foo(): Foo {
    return pb_1.Message.getWrapperField(this, Foo, 1) as Foo;
}

This advertises that Foo is unconditionally available, but in fact sometimes it can be undefined.

I've been confused a couple times when my TypeScript code ran into undefined values that shouldn't have been possible according to annotated types. :)

from protoc-gen-ts.

You are definitely right about this. getters should be annoted as possibly return undefined cause they are optional. May be we could leverage a feature of typescript which could be some kind of "optional chaining feature" designed for "return" statements. Or maybe we could just use Type | undefined | null as type annotation.

I'm not sure what we should use.

from protoc-gen-ts.

Ah, I saw that this issue was closed, so I thought the as Foo (vs. as Foo|undefined) issue had been fixed. But I guess the main bug here was different.

Should I open a separate issue for the Foo vs. Foo|undefined type problem?

(Unrelated: I'm using the generated code in Deno (with a very small manual update) and it seems to be working well so far!)

from protoc-gen-ts.