Git Product home page Git Product logo

Comments (3)

johnnyasantoss avatar johnnyasantoss commented on June 22, 2024
diff --git a/src/descriptor.ts b/src/descriptor.ts
index f70441d..e9d53b5 100644
--- a/src/descriptor.ts
+++ b/src/descriptor.ts
@@ -188,10 +188,17 @@ function createFromObject(
             [ts.factory.createIdentifier("item")],
           ),
         );
-        assignmentExpr = ts.factory.createCallExpression(
-          ts.factory.createPropertyAccessExpression(assignmentExpr, "map"),
-          undefined,
-          [arrowFunc],
+        assignmentExpr = ts.factory.createBinaryExpression(
+          ts.factory.createCallExpression(
+            ts.factory.createPropertyAccessChain(assignmentExpr, ts.factory.createToken(ts.SyntaxKind.QuestionDotToken), "map"),
+            undefined,
+            [arrowFunc],
+          ),
+          ts.factory.createToken(ts.SyntaxKind.QuestionQuestionToken),
+          ts.factory.createArrayLiteralExpression(
+            [],
+            false
+          )
         );
       } else {
         assignmentExpr = ts.factory.createCallExpression(

Would adding such a change be a proper fix? I have no experience with ts factory

This would only change the codegen for repeated messages

from protoc-gen-ts.

thesayyn avatar thesayyn commented on June 22, 2024

Do you mind sending a PR so we can what see the output of this change?

from protoc-gen-ts.

johnnyasantoss avatar johnnyasantoss commented on June 22, 2024

hey @thesayyn just created #202, let me know if that has any value. It does add a default but I'm not sure if it is a proper fix.

from protoc-gen-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.