Using a local eslint makes node load a shell script about eslint-formatter HOT 7 CLOSED

For me, on windows, it's a shell script:

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/../eslint/bin/eslint.js" "$@"
  ret=$?
else 
  node  "$basedir/../eslint/bin/eslint.js" "$@"
  ret=$?
fi
exit $ret

from eslint-formatter.

#17 hasn't been released yet.

This is an interesting issue. I wonder why calling node_modules/.bin/eslint would cause errors. It should just be a symlink to the file in node_modules/eslint/bin:

lrwxr-xr-x   1 me  staff    23B Jun 30 01:56 eslint -> ../eslint/bin/eslint.js

from eslint-formatter.

Look at that, I just learned something new about npm on windows.

I'd happily accept a pull request for this case. I unfortunately don't have any easy way to test and validate that functionality.

from eslint-formatter.

I mean, I'm not sure why on windows it makes a shell file of all things, but hey!

I'll try changing it to search for node_modules/eslint/bin/eslint instead of node_modules/.bin/eslint and see if it works for me.

from eslint-formatter.

I'm thinking we'd likely want to continue running the normal .bin/eslint file on non-windows platforms. I'm kinda leaning towards the "If it aint broke, don't fix it" mentality. Especially since we haven't figured out how to write tests for this repo.

from eslint-formatter.

The default global path on windows is already eslint/bin/eslint, but the other OSes go to the generic bin folder.

Do you want me to make a pull request that duplicates the eslint_path setting for local search paths? I imagine it'd look like:

  // The location to search for a locally installed eslint package
  // If this is not found, it will try to use the global package (see 'eslint_path')
  "local_eslint_path": {
    "windows": "./node_modules/eslint/bin/eslint",
    "linux": "./node_modules/.bin/eslint",
    "osx": "./node_modules/.bin/eslint"
  },

from eslint-formatter.

Yeah, that seems like a reasonable approach, thanks.

from eslint-formatter.