Comments (2)
Glancing at it pre-coffee, sounds right, but still need to confirm. Good eye and very sorry!
It sounds like a simple enough fix but we need to find a better testing strategy for this class, it's always been a bit touchy. Perhaps an integration test via the Command Bus would be easier...
I'll need to look at this one in more depth. If you'd like to take a crack at producing a unit test for it, I'd be more than glad to merge and review. If not, it might take me a few days to get to it but I appreciate your raising this issue nonetheless. Thanks!
from tactician.
Closing this one now that #62 is merged. Thanks a ton @angun33, we'll tag a new release soon to fix this. 😄
from tactician.
Related Issues (20)
- [RFC] Chained Inflector HOT 4
- [DOC] Missing parameter HOT 3
- We created queue interop based middleware for tactician. HOT 1
- Testing with no interface HOT 2
- LICENSE file missing for re-distribution HOT 1
- V2: InMemoryLocator replacement? HOT 2
- Delete the 2.0 branch HOT 1
- Implement CommandBus against interface HOT 4
- Broken Examples HOT 8
- PHP8 Support HOT 1
- Release v2 HOT 14
- RFC: Add markdown linting for `gh_pages` HOT 1
- Make Middleware::execute internal HOT 6
- Locking middleware does not work with exceptions HOT 9
- PHP version constraint tigher than required HOT 5
- Plugin to prioritize command HOT 3
- Scheduling commands HOT 2
- Yii adapter for Tactician HOT 2
- 1.0 release ? HOT 2
- Tests missing in releases HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tactician.