Preventing a loop when dealing with external commands about tactician HOT 3 CLOSED

I am generally against the idea of making the ExternalCommandMiddleware aware of any detection and limitation logic. I said in the referenced issue that it is not the way it should work. I showed several scenarios (although probably not all of them are in the referenced issue). The point is the same codebase argument is less important IMO than having clean, decent code.

(Honestly, the more I think about this idea, the more I think it is bad....very bad. However I can imagine adding an envelope logic (besides Bernard\Envelope) and unwrapping it somewhere so that it can't be requeued. However that should go into a separate setup like LazyQueueMiddleware)

from tactician.

@acairns As suggested in thephpleague/tactician-bernard#11, we could avoid the loop by using a different type of wrapping for the second pass. I know you're using a different queuing system than Bernard, but perhaps we can continue the convo there because I suspect the ultimate solution is always the same and it's easier than chasing across multiple threads 😄

from tactician.

Sure thing!

from tactician.