Problems adding DropBox as a provider about oauth2-client HOT 10 CLOSED

Thanks, I'll take a look in a bit.

Emailing from my iPhone like a BOSS

On 24 Nov 2013, at 08:09, Jean-Nicolas Boulay [email protected] wrote:

I tried to add DropBox as a provider.

Here is my code: https://gist.github.com/jnbdz/7624654

I was actually able to solve the problem quickly, but I think this is something you guys should think about for your next version.

To make DropBox work I had to comment out line 70:

//'approval_prompt' => 'force' // - google force-recheck

The problem then is if I want to use Google it won't work anymore...

—
Reply to this email directly or view it on GitHub.

from oauth2-client.

This has already changed in master.

—
Sent from Mailbox for iPhone

On Sun, Nov 24, 2013 at 7:30 AM, Alex Bilbie [email protected]
wrote:

Thanks, I'll take a look in a bit.

Emailing from my iPhone like a BOSS

On 24 Nov 2013, at 08:09, Jean-Nicolas Boulay [email protected] wrote:

I tried to add DropBox as a provider.

Here is my code: https://gist.github.com/jnbdz/7624654

I was actually able to solve the problem quickly, but I think this is something you guys should think about for your next version.

To make DropBox work I had to comment out line 70:

//'approval_prompt' => 'force' // - google force-recheck

The problem then is if I want to use Google it won't work anymore...

—

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub:
#40 (comment)

from oauth2-client.

That was quick.

from oauth2-client.

I just look at the code and I still see:

'approval_prompt' => 'force' // - google force-recheck

Maybe you can add a "if" to see if it is a Google provider being used, to then add it afterwards with array_merge or something.

from oauth2-client.

I was wrong, its not I'm master but there is a PR for it:

https://github.com/php-loep/oauth2-client/pull/23/files

Test it out and see if it helps.

Phil Sturgeon

On Sunday, November 24, 2013 at 11:51 AM, Jean-Nicolas Boulay wrote:

I just look at the code and I still see:
'approval_prompt' => 'force' // - google force-recheck
Maybe you can do an if to see if it is Google provider to then add it afterwards with array_merge or something.

—
Reply to this email directly or view it on GitHub (#40 (comment)).

from oauth2-client.

Heads up, I working on an example app which uses this library so that we can test pull requests against

On 24 Nov 2013, at 16:54, Phil Sturgeon [email protected] wrote:

I was wrong, its not I'm master but there is a PR for it:

https://github.com/php-loep/oauth2-client/pull/23/files

Test it out and see if it helps.

Phil Sturgeon

On Sunday, November 24, 2013 at 11:51 AM, Jean-Nicolas Boulay wrote:

I just look at the code and I still see:
'approval_prompt' => 'force' // - google force-recheck
Maybe you can do an if to see if it is Google provider to then add it afterwards with array_merge or something.

—
Reply to this email directly or view it on GitHub (#40 (comment)).

—
Reply to this email directly or view it on GitHub.

from oauth2-client.

@alexbilbie bump

from oauth2-client.

Noted.

from oauth2-client.

I closed PR #23, as the repository is dead and the author just confirmed that it is dead. I'll keep this issue open, as we may need another PR for it.

from oauth2-client.

I believe PR #220 has fixed this. If it's still not fixed, please reopen this issue.

from oauth2-client.