Comments (6)
I totally get your point and I'm on your side with that. I had the issue with people being unable to join lobbies because sharing the settings somehow didn't want to work when using string ids. Sadly I never got to the bottom of it, you probably did in the mean time? As my changes were not practical and as you're saying yourself... odd... there was no sense in opening a PR. You're right I should have opened an issue or feature request, sorry for that. You're also right with the lobby text patch, I just entered some dirty spacings/some tabs and colors in there (some of the features you already added to Essentials). I changed some accessibility levels because I needed access in order to add some settings presets you can switch through (probably not something that would make sense to be added to Essentials, especially not in the way that I've implemented it).
If possible I'd also be in my interest to switch back to the orginal Essentials (or maybe to a small fork where I just change the accessibility levels, as that would not break compatibility and enable me to implement my presets). I'll try to do that asap π Is the issue still there regarding the string ids or am I missing something stupid there? :)
from theotherroles.
The issue is regarding UDP packet sizes, 0.2.0-dev.8 will address this within a few days.
from theotherroles.
Awesome, then I'll switch back with the new version βοΈ Thank you for your work.
from theotherroles.
0.2.0-dev.8 is now up, please let me know if you still experience a similar issue with the options not syncing, or any other issue you come across or feature you may need.
from theotherroles.
Thank you for the update, already switched locally π I'm planning to still use a small variation of your Essentials, which only modifies 3 variablie accessibility levels (3x the ConfigEntry to pulbic). My use case is that I change the bind depending on a "preset option" (only for the settings that match my pluginId), so that I can store e.g. 4 different values for one option and switch between them by switching the preset setting. Do you still want me to create and link a fork there (as it doesn't affect compatibility at all and only three accessibilty levels changed) or are you fine with me just using that slight variation without pointing it out?
from theotherroles.
You can create derivatives of the option classes (in your mod) and add additional ConfigEntry
fields for the presets, so you'd have one (the default) for the "active" preset and your additional ones to store presets, call SetValue
to apply the selected preset.
And yes I'd like all modifications of Essentials to follow the license and post modifications of the code if any are made.
from theotherroles.
Related Issues (20)
- [Bug Report] when you play on freeplay thee submerged map and finish a vote and then select the location the game frezez and on the upper flor there are some walls missing ( in cafeteria , in comunications , in the hallway that leads from upper lobby to comunications and in reseach look very closely . pls fix the bug and put the walls HOT 3
- Banning a player is not possible HOT 2
- [Suggestion] The "Spectre" HOT 1
- [Suggestion] The "Illusionist" HOT 1
- [Suggestion] The "Butcher" HOT 1
- subway worker HOT 1
- [Bug Report] Map: Fungal | Out of the map with anti-tp HOT 1
- [Bug Report] HOT 2
- [Ask] How to get in debug mode? HOT 1
- [Bug Report] I canβt get the stuff into Among us
- Steam Authorization Works HOT 2
- Killing someone in Prophunt crashes the round and everyone except the killer and the one who got killed gets kicked HOT 1
- [Bug Report] Roles shown even when their percentage is 0% HOT 9
- [Suggestion] Kill animation for guesser during meetings HOT 1
- Mods not running on Mac using Whiskey HOT 3
- [Bug Report] Crewmates can teleport Imposters to vents they've been in before HOT 2
- Crash on startup HOT 7
- [Bug Report] Tracker Arrow persists After Death
- [Bug Report] "Snitch is Alive" after DC
- [Bug Report] Game crash after new update HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from theotherroles.