Git Product home page Git Product logo

Comments (4)

CouchofTomato avatar CouchofTomato commented on June 20, 2024

@TheOdinProject/javascript Can someone please review.

from curriculum.

thatblindgeye avatar thatblindgeye commented on June 20, 2024

@Hachibroku do you feel even the assigned resource - MDN's DOM Manipulation - doesn't exactly satisfy going over the difference between the two?

If not, then adding a short blurb may not be a bad idea. We should try to keep it succinct, though, just due to how much content the lesson is already covering. Depending on your thoughts to the above question, we can move forward from there.

from curriculum.

Hachibroku avatar Hachibroku commented on June 20, 2024

@thatblindgeye After re-reading the materials and improving my own understanding of the content, I think that one should be able to understand how 'element' and 'node' relate to each other, but it is somewhat obscured by the lesson. Of the resources linked in the lesson, Digital Ocean - Understanding the DOM Tree and Nodes contained the explanation I was looking for.

I think directly addressing node types and how we're using them would improve the clarity of the lesson overall. For example, an appendage to the paragraph under the Document Object Model heading so it now reads;

The DOM (or Document Object Model) is a tree-like representation of the contents of a webpage - a tree of “nodes” with different relationships depending on how they’re arranged in the HTML document. There are many types of node, most of which are not commonly used. In this lesson we will be focusing on "element" nodes which are primarily used for manipulating the DOM.

or the same information in a separate, clarifying blurb may work better than trying to integrate into the existing content.

I think it may also help to change the final sentence in the paragraph under the DOM Methods heading to say

those that help you target elements.

instead of

those that help you target nodes.

since query selectors specifically work with elements, and it reinforces the node type.

from curriculum.

thatblindgeye avatar thatblindgeye commented on June 20, 2024

I think your tweak to the first paragraph sounds good. I'd also be fine with your other suggestion, though we could also just remove that sentence entirely since it doesn't really feel all that necessary to say "First we'll cover [thing]. (heading for [thing] on the very next line)".

Assigned you to the issue, though!

from curriculum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.