Comments (2)
Thanks for opening this issue, @nguyenlekhtn. I've noticed this step is a common source of confusion amongst learners.
The instruction's intention is to return an array of values only if no callback is provided. If a callback is provided, it should just be called on each Node as you traverse the tree, without returning anything. Basically like Array.prototype.forEach
but with a default behaviour in the case of no callback.
However, this does feel a bit strange as the default behaviour is very different in nature to when a callback is provided. Since this (and the next step with the different traversal orders) is effectively like Array.prototype.forEach
(only with a specific traversal order), I'm wondering if the instructions for this and the following step should be adjusted so that instead of returning an array of values in the case of no callback, it throws an error saying it expects a callback?
I believe this would make it more intuitive and also be more in line with how you'd expect such a method to work anyway. @TheOdinProject/ds-a thoughts?
from curriculum.
Related Issues (20)
- JS - A Quick Review: Modify recommendations for reviewing JS HOT 2
- Function Basics: Extend note on not doing the MDN exercises to the second exercise bullet point HOT 4
- Easy fix: 'recommend' should be in past tense in the following context HOT 1
- Getting Started NodeJS Course - New 2024 TraversyMedia crash course video suggestion. HOT 8
- Styling React Applications(React): clarifications regarding Tailwind CSS as a styling option HOT 1
- Update Lesson: Deployment HOT 1
- Update Lesson: Authentication Basics HOT 1
- Foundations Command Line Basics: External UNIX Shell course uses Nano HOT 5
- How This Course Will Work: Double 'the' in 'A note about tools' HOT 1
- React: Update lesson to remove `defaultProps` HOT 15
- Introduction To React Testing: add "Testing Implementation Details" by Kent C. Dodds HOT 1
- JavaScript: Update place ship instruction HOT 1
- Deployment: Outdated Fly.io Information HOT 1
- Express 102: CRUD and MVC: <Short description of your suggestion> HOT 2
- Foundation - Axes: shows code before code HOT 3
- Git Basics: <Accessibility of screenshots> HOT 4
- Foundations[Arrays and Loops] : Map/Filter/Reduce before they are taught. HOT 3
- New Lesson: Environment Variables HOT 5
- Setting up Git: <options for setting up git> HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from curriculum.