Cleaning Snapshots about node-eventstore HOT 11 CLOSED

At the moment, I have muted other stores tests, because I don't know if I will be able to implement it in every stores.
A little help would be great !
I also don't know how to allow people to contribute to what will become a PR on this project.
Note that, in the base store, snapshots cleaning remain silent (only a warning) if not implemented in the store used by an application

from node-eventstore.

I would do the cleaning in combination with cqrs-domain.
exactly how you have done it... but without waiting for completion (fire and forget)
just catch if there is an error here and log in in debug... => rehia@a945ad2#diff-f641dc482370f1ff504efc63b483ccccR381

from node-eventstore.

It would be nice if you could do the mongodb implementation too (just if you want)...

from node-eventstore.

I've done a few things:

• implementing snaphost cleaning for mongodb and elasticsearch. it seems optimized for elasticsearch, not sure for mongodb...
• I've just changed a bit when snapshot cleaning is called: even when adding snapshot fails

Let met know if you see other things before submitting the PR

from node-eventstore.

Seems ok,
btw: tingodb has the same api of mongodb ;-)

from node-eventstore.

haha 😅
didn't know anything about tingo before 😁
i'll try to do it.
just need to grab the docker image to test.

I also need to make some real world tests on my project, with a huge amount of snapshots, to see if everything is ok.
I'll let you know

from node-eventstore.

done !
as long as the tests in real world.
Seems to work pretty good !
Just need a release !

from node-eventstore.

v1.12.0

from node-eventstore.

ok thanks @adrai !
i'll take a look at redis indexation to have more efficient scans

from node-eventstore.

no time to contribute atm, but just want to leave a quick thank you!

from node-eventstore.

@rehia I had to exclude elasticsearch the search function has some errors (no idea why)

from node-eventstore.