Discuss ways to avoid `new Function` in denodeify about promise HOT 1 OPEN

I'm not super keen to rely on Proxy, and from what I recall, the primary reason we use new Function is actually for performance. In the case where we know the number of arguments up front, we can generate more optimised code that does not need to copy the arguments pseudo array.

One option might be to add a few prebuilt functions for 0, 1, 2, 3 and 4 arg functions. We could then avoid the runtime code generation until faced with a function that takes a large number of arguments.

In terms of performance, I'd want to see us doing the same or better in all the bluebird benchmarks https://github.com/petkaantonov/bluebird/tree/master/benchmark

In terms of having multiple versions, we so have a version for "domains" support and a version that uses "setImmediate" directly instead of asap. These are generated using the build.js script. We could add another output for content-security-policy compliance, which could either use your Proxy approach, or just skip enforcing the length of returned functions.

from promise.