Don't be dependent on react-router-dom about flowbite-react HOT 6 CLOSED

@rluders Yeah, it could be as simple as optionally passing an override to the Link component. And rather than using react-router useLocation, use window.href.pathname instead for the current route.

from flowbite-react.

Hi @KaiSpencer,

Thanks for opening the issue. May I ask you for some more information?

• What is the goal here?
• What would the benefits be?

I don't get it, maybe @tulup-conner could help us here since he is heavily working on the Sidebar component. But, if you are talking to remove dependency libraries I'm always interested. 👍

from flowbite-react.

Hi @rluders

Sure thing, the sidebar requires react-router, it uses a hook to determine the url and the Link component to handle navigation. This isn't something that every react application wants by default. I think client side routing should be opt in for the component

In my scenario I use Nextjs with its own router and don't want to have to switch to client side routing just to use this component.

MUI may be a good starting point to take some hints how to handle supporting various routing libraries.
https://mui.com/material-ui/guides/routing/#main-content

from flowbite-react.

@KaiSpencer all right... I think that I got it., but please correct me if I'm wrong.

The overall idea is to allow the sidebar component to receive a "router adapter" to use internally to generate the links. So the user can easily replace it in order to use the router that best fits his application.

Something like this? It sounds like a good idea IMHO.

from flowbite-react.

Yea I agree completely. It's already being used in another component so I added it thinking that was the intended way to go.

I didn't think about the fact that react-router in Next takes on the role of client side routing. That is definitely not desirable. I'm spoiled by Remix.

from flowbite-react.

OK. So, I guess that we agree that remove the react-router and to add the flexibility to use others routers librabries is something that we want.

@KaiSpencer if you want to go ahead and submit a PR implementing this feature we gonna be happy to review it and accept.

from flowbite-react.