Footer is overrided by the valine comment in mobile [solved] about hexo-theme-next HOT 11 CLOSED

Well, your footer height is too large.
In the default, $footer-height is 50px and the $gap-between-main-and-footer is 100px, the footer height will be up to 150px.

But in your page the footer height, in the desktop layout, is 180px, and in the mobile layout, the height is 208px.

Now you can just change the $footer-height in the file next/source/css/_variables/base.styl.

PS: Maybe there need an option in the theme config file, which allows the users define their own footer-height (like footer.min_height)? @ivan-nginx whats your opinion?

from hexo-theme-next.

yes, thank u. i did add content in the footer page...

from hexo-theme-next.

I think need to:

1. Check other comment systems (disqus, etc.). If there are works fine, write to Valine repo about bug.
2. If on other comment systems see the same, then need to see scheme templates. Need to try:
   2.1. Reset all custom footer styles.
   2.2. Test on other schemes (Gemini must have auto footer adjustments, 3 other shemes not).

It's a not critical bug, but need to be fixed.

next/source/css/_variables/base.styl

No. This path for all schemes and for global variables. Need to change footer only for current scheme in:

• source/css/_mixins/Muse.styl or in
• source/css/_schemes/Muse/index.styl or in
• source/css/_variables/Muse.styl.

Base variables what give on all schemes need to edit only if all schemes have same bug. Often was cases, when peoples fix 1 bug for 1 scheme in global vars, but other bug in other schemes will appear after this.

Later i create something like edit instructions on schemes styles.

from hexo-theme-next.

Got it. 👍

But I think his problem is not the comments issues, it's the issue that his footer is too high and covering the main block.

When you fill too many things into the footer, it will cause the issues (except the Gemini scheme).

Steps to reproduce:

1. Reset all the settings.
2. Uncomment the footer.custom_text in the theme/_config.yml, and fill texts with several <br/> or some wide words.
3. Enable a scheme except Gemini.
4. Start the server and take a look.

from hexo-theme-next.

1. test different scheme

• in the Mist, there is a clear cut between the comment and footer, the powered by the valine is missing, that might otherwise be obscured. the gap between the comment and footer in my custom page is also clear.

• in the Pisces, there has still overlapping phenomenon in post and my custom page

• in the Gemini, it's fine for its auto footer adjustments.

• test the comment system, there is also have overlapping phenomenon in post and my custom page.

Now i just change the $footer-height to 100px in the file next/source/css/_variables/base.styl, it works.

from hexo-theme-next.

Ok, i think need to add something like auto-height on footer, like on Gemini.

from hexo-theme-next.

there is no problem using footer.custom_text provided in _config.yml instead of add content in /layout/_partials/footer.swig manually.
BUT when there are too many content in footer, it's still a problem.

from hexo-theme-next.

custom_text: Hosted by <a target="_blank" rel="external nofollow" href="https://pages.github.com">GitHub Pages</a><br>Hosted by <a target="_blank" rel="external nofollow" href="https://pages.github.com">GitHub Pages</a><br>Hosted by <a target="_blank" rel="external nofollow" href="https://pages.github.com">GitHub Pages</a>

from hexo-theme-next.

This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from hexo-theme-next.

@sli1989 problem still exists?

from hexo-theme-next.

For me, I know the solutions.
For Next, like u said: Ok, i think need to add something like auto-height on footer, like on Gemini. for the situation: Somebody wants to add too many content in footer.

from hexo-theme-next.