Git Product home page Git Product logo

Comments (7)

leifj avatar leifj commented on August 12, 2024

Confirmed. I'm pretty sure the issue is in cta/index.js where we only look at entityID instead of using that as a fallback.

from thiss-js.

leifj avatar leifj commented on August 12, 2024

I've pushed a PR - can you test integration with https://deploy-preview-137--thiss.netlify.app/ and tell me if you can see any issues?

from thiss-js.

Kublicki avatar Kublicki commented on August 12, 2024

Hey Leif,

I can still see both attributes present in the storage (some identifiers removed):

{ "last_refresh": 1615304223944, "last_use": 1615304223944, "entity": { "title": "MY ENTITY", "descr": "MY ENTITY", "title_langs": { "en": "University of ..." }, "descr_langs": { "en": "University of ..." }, "auth": "saml", "entity_id": "urn:...", "entityID": "urn:...", "type": "idp", "hidden": "false", "scope": "MY SCOPE", "domain": "MY SCOPE", "name_tag": "GTY", "id": "{sha1}..." } }

I would expect to see only entity_id - is that correct?

from thiss-js.

leifj avatar leifj commented on August 12, 2024

No you should still see both attributes. My fix simply deals with both of them in the standard integration.

from thiss-js.

Kublicki avatar Kublicki commented on August 12, 2024

Does it mean, if a service provider sets up only entity_id attribute (using advanced implementation) and another service provider uses standard implementation persistence service should work both ways between those service providers?

from thiss-js.

leifj avatar leifj commented on August 12, 2024

yes that is the idea

from thiss-js.

leifj avatar leifj commented on August 12, 2024

OK I'm gona mark this as closed. It will get rolled out to testing with a bunch of other stuff.

from thiss-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.