Comments (7)
Confirmed. I'm pretty sure the issue is in cta/index.js where we only look at entityID instead of using that as a fallback.
from thiss-js.
I've pushed a PR - can you test integration with https://deploy-preview-137--thiss.netlify.app/ and tell me if you can see any issues?
from thiss-js.
Hey Leif,
I can still see both attributes present in the storage (some identifiers removed):
{ "last_refresh": 1615304223944, "last_use": 1615304223944, "entity": { "title": "MY ENTITY", "descr": "MY ENTITY", "title_langs": { "en": "University of ..." }, "descr_langs": { "en": "University of ..." }, "auth": "saml", "entity_id": "urn:...", "entityID": "urn:...", "type": "idp", "hidden": "false", "scope": "MY SCOPE", "domain": "MY SCOPE", "name_tag": "GTY", "id": "{sha1}..." } }
I would expect to see only entity_id - is that correct?
from thiss-js.
No you should still see both attributes. My fix simply deals with both of them in the standard integration.
from thiss-js.
Does it mean, if a service provider sets up only entity_id attribute (using advanced implementation) and another service provider uses standard implementation persistence service should work both ways between those service providers?
from thiss-js.
yes that is the idea
from thiss-js.
OK I'm gona mark this as closed. It will get rolled out to testing with a bunch of other stuff.
from thiss-js.
Related Issues (20)
- Contenthash in filenamse
- Pre expire of IdP:s
- Hide button image from screen readers
- Missing lang attributes in Standard button
- Wrong language of the html tag for the Discovery Service
- Re-work the focus settings of the Standard button
- The Standard button should have a mouse-over color
- Add aria-labelledby to Find Your Institution HOT 1
- Notify the user when search results are selectable
- Examples are not headers
- Requests are not properly proxied to pyff
- add a method to remove all entries for a context in PersistenceService
- Support running the ds on a path other then /
- `make docker` refuses to build because node version is too old HOT 2
- mdq_browser problems HOT 1
- Increase target size of "delete" institution HOT 1
- Show chevron on also on:focus in the list
- `make setup` fails on Mac HOT 1
- Indicate unable to verify returning site HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thiss-js.