Help me make this library easy to use about genegenie.geocoder HOT 6 CLOSED

Hey Ryan,
I'm a new programmer with decent documentation skills. But I just started on GitHub. How may I be of help?

from genegenie.geocoder.

Hi (Sam?),

I'd be interested in your help with making it so it is easy to get started. I'm aware there are a few steps missing from the 'get started' steps, such as 'Now get an API key for Bing (from here) and Google (from here)', help on that would be good.

Constructive criticism is welcome too, for example 'I've no idea what this bit does, why do I need that etc?'.

Trying to use the package should hopefully show any issues.

Does that sound OK? Happy to get involved.

from genegenie.geocoder.

To avoid putting keys in source, override in appsettings.Development.json or environment vars, never here.

So should I be making this json file, yes? I don't see it in the source
Not exactly sure which environment vars its referring to

from genegenie.geocoder.

Ok, that could be clearer then. I'll see about rewording / reworking it.

For the example console app (which is where I think you've got that text from), that's more a note to me so that I don't put any keys in source. You can enter your API keys there (just don't push them to github) or you can set them as environment variables using the standard .Net Core configuration approach which keeps them out of source again (see https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-2.1#environment-variables-configuration-provider).

.Net Core configuration also handles picking up the appsettings.Development.json so you can create that file in the console app and then populate them in there (you'd keep that file out of source).

That should be enough to get the sample console app working for you. I'll see if I can make it more obvious.

Perhaps .Net Core is making it too difficult to use with config and Dependency Injection.

Does that help at all?

from genegenie.geocoder.

Hey Ryan,

I'm interested in taking a look at how to display the test status from Azure Devops.

In Azure Devops are the tests running as part of a CI pipeline or are you using Test Plans?

from genegenie.geocoder.

Hi Nick,

I ditched Azure DevOps in the end and just went to AppVeyor for everything. Much easier. ADO was missing lots of functionality (or it was not easy to discover) such as plugging onto SonarQube, test coverage badges etc.

from genegenie.geocoder.