Running pubsub_unsubscribe with no arguments seems to stop everything about tornadis HOT 8 CLOSED

Using a yield self.client.pubsub_punsubscribe('sample:*') seems to be a workaround, if you use a prefix for everything, but according to redis docs running unsubscribe should unsubscribe from everything

from tornadis.

you are right => let's fix it

from tornadis.

I suppose you can use yield self.client.pubsub_punsubscribe('*') as a real workaround

from tornadis.

thanks

from tornadis.

Thanks for fixing this, it's more straightforward error now, curious to know why this is an error instead of unsubscribing all like the redis docs.

from tornadis.

I don't understand your comment.

see b171af9 new test

you can use pubsub_punsubscribe and pubsub_unsubscribe without args (as redis docs said)

but

pubsub_psubscribe and pubsub_subscribe will raise a ClientException if there is no args (as redis docs)

from tornadis.

just merged this in tornado42 branch (BTW)

from tornadis.

Oh it was just a misunderstanding. I now see you fixed those other errors as well.

Sent from my iPhone

On 4 Aug 2015, at 11:45 pm, Fabien MARTY [email protected] wrote:

I don't understand your comment.

see b171af9 new test

you can use pubsub_punsubscribe and pubsub_unsubscribe without args (as redis docs said)

but

pubsub_psubscribe and pubsub_subscribe will raise a ClientException if there is no args (as redis docs)

—
Reply to this email directly or view it on GitHub.

from tornadis.