Git Product home page Git Product logo

Comments (14)

tombigel avatar tombigel commented on June 2, 2024 2

I created a pr #10

from svg-path-commander.

thednp avatar thednp commented on June 2, 2024 1

I'm not sure, but a test site would help. Might be related to an older version, you sure you're up to date?

Anyways, I'm planning to add Cypress testing suite to SVGPathCommander and remove any remaining bugs.
Perhaps sooner than expected.

from svg-path-commander.

tombigel avatar tombigel commented on June 2, 2024

@thednp I'm getting the same error, using the skypack version (https://www.skypack.dev/view/svg-path-commander)

The bug is in line 205 in svg-path-commander.js

If origin is not passed to any .transform() operation (also flipX/Y etc.) the transform function spreads origin to an object instead of an array -

 } else {
      transform.origin = {...this.origin};
    }

should be :

 } else {
      transform.origin = [...this.origin];
    }

from svg-path-commander.

lordanubi avatar lordanubi commented on June 2, 2024

Having the same problem in React but this doesn't fix it:

 } else {
      transform.origin = [...this.origin];
    } 

from svg-path-commander.

thednp avatar thednp commented on June 2, 2024

@lordanubi have a minute to produce a test repo.

from svg-path-commander.

thednp avatar thednp commented on June 2, 2024

@brianakidd I can confirm the fix is solid for me. I'm ready to push v0.1.26 to the cloud.

V0.2.0 will feature Cypress testing.

from svg-path-commander.

brianakidd avatar brianakidd commented on June 2, 2024

@thednp Sounds great. Thanks

from svg-path-commander.

thednp avatar thednp commented on June 2, 2024

@lordanubi we're waiting for your confirmation.

from svg-path-commander.

thednp avatar thednp commented on June 2, 2024

@brianakidd @lordanubi @tombigel please test latest master and let me know how it goes, Cypress testing is added to the main class, later to add for all statics, have fun!

from svg-path-commander.

thednp avatar thednp commented on June 2, 2024

@brianakidd @lordanubi @tombigel should we close this?

from svg-path-commander.

lordanubi avatar lordanubi commented on June 2, 2024

I'm not getting the error anymore with last version but I noticed that flipX() and flipY() do the same thing have you checked that?
Anyway thanks for your hard work! Keep it up :)

from svg-path-commander.

thednp avatar thednp commented on June 2, 2024

@lordanubi perhaps your shape is a square or a circle?

from svg-path-commander.

lordanubi avatar lordanubi commented on June 2, 2024

whooops sorry it was my setup buggin as fuck, it works like a charm! Thanks again you can definitely close this

from svg-path-commander.

tombigel avatar tombigel commented on June 2, 2024

sorry, was on holiday.

from svg-path-commander.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.