Comments (14)
I created a pr #10
from svg-path-commander.
I'm not sure, but a test site would help. Might be related to an older version, you sure you're up to date?
Anyways, I'm planning to add Cypress testing suite to SVGPathCommander and remove any remaining bugs.
Perhaps sooner than expected.
from svg-path-commander.
@thednp I'm getting the same error, using the skypack version (https://www.skypack.dev/view/svg-path-commander)
The bug is in line 205 in svg-path-commander.js
If origin is not passed to any .transform() operation (also flipX/Y etc.) the transform function spreads origin
to an object instead of an array -
} else {
transform.origin = {...this.origin};
}
should be :
} else {
transform.origin = [...this.origin];
}
from svg-path-commander.
Having the same problem in React but this doesn't fix it:
} else {
transform.origin = [...this.origin];
}
from svg-path-commander.
@lordanubi have a minute to produce a test repo.
from svg-path-commander.
@brianakidd I can confirm the fix is solid for me. I'm ready to push v0.1.26 to the cloud.
V0.2.0 will feature Cypress testing.
from svg-path-commander.
@thednp Sounds great. Thanks
from svg-path-commander.
@lordanubi we're waiting for your confirmation.
from svg-path-commander.
@brianakidd @lordanubi @tombigel please test latest master and let me know how it goes, Cypress testing is added to the main class, later to add for all statics, have fun!
from svg-path-commander.
@brianakidd @lordanubi @tombigel should we close this?
from svg-path-commander.
I'm not getting the error anymore with last version but I noticed that flipX() and flipY() do the same thing have you checked that?
Anyway thanks for your hard work! Keep it up :)
from svg-path-commander.
@lordanubi perhaps your shape is a square or a circle?
from svg-path-commander.
whooops sorry it was my setup buggin as fuck, it works like a charm! Thanks again you can definitely close this
from svg-path-commander.
sorry, was on holiday.
from svg-path-commander.
Related Issues (20)
- Code Review HOT 6
- Unsupported implicit `lineTo` when using additional `moveTo` parameters HOT 6
- Transforms on g elements HOT 9
- path2Curve produces wrong result when converting L command HOT 8
- Support custom `document` on `shapeToPath`
- How to apply 4x4 matrix using SVG path commander HOT 2
- Subdividing paths/curves? HOT 2
- Scale transform doesn't take into consideration the origin property HOT 5
- README logo is hard to see in dark mode HOT 3
- About the lineToCubic algorithm. HOT 2
- Unable to import and use default export in vite/sveltekit HOT 6
- shapeToPath can't infer RectAttr type as param HOT 4
- can shapeToPath return a PathArray or SVGPathCommander? HOT 3
- support native DOMMatrix and/or CSSMatrix for transform HOT 2
- default origin documentation HOT 2
- getSVGMatrix not exposed HOT 2
- Apply a matrix transform to a path HOT 8
- Transformation of the path containing the arch HOT 1
- create path from stroked shape/path HOT 2
- toRelative does not convert absolute moveTo commands in additional segments HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svg-path-commander.