Git Product home page Git Product logo

Comments (11)

dwf avatar dwf commented on June 12, 2024

Is this in theano stable as well?

from theano.

pascanur avatar pascanur commented on June 12, 2024

Yes I think so. This was introduced long long time ago. I've tried at one
point to fix it (before we moved to git) but it turned out not to be a
trivial task. I'll give it another go,
but know that this will not be done in a matter of minutes :(. Maybe I can
disable scan working on GPU for now removing the import (that should be
quick) and work on
repairing the damage afterwards.

Razvan

On Thu, Oct 20, 2011 at 8:53 PM, David Warde-Farley <
[email protected]>wrote:

Is this in theano stable as well?

Reply to this email directly or view it on GitHub:
#134 (comment)

from theano.

pascanur avatar pascanur commented on June 12, 2024

I've looked through the code. cuda is imported only inside two functions
(exactly where I need it) when you use scan. So is it that the code that
generates the error actually uses scan, or this error happens even if you do
not use scan?

Razvan

On Fri, Oct 21, 2011 at 8:39 AM, Razvan Pascanu [email protected] wrote:

Yes I think so. This was introduced long long time ago. I've tried at one
point to fix it (before we moved to git) but it turned out not to be a
trivial task. I'll give it another go,
but know that this will not be done in a matter of minutes :(. Maybe I can
disable scan working on GPU for now removing the import (that should be
quick) and work on
repairing the damage afterwards.

Razvan

On Thu, Oct 20, 2011 at 8:53 PM, David Warde-Farley <
[email protected]>wrote:

Is this in theano stable as well?

Reply to this email directly or view it on GitHub:
#134 (comment)

from theano.

jaberg avatar jaberg commented on June 12, 2024

This seems straightforward, no?

  1. https://github.com/Theano/Theano/blob/master/theano/__init__.py#L80

  2. https://github.com/Theano/Theano/blob/master/theano/scan_module/scan.py#L56

On Fri, Oct 21, 2011 at 10:35 AM, Razvan Pascanu
[email protected]
wrote:

I've looked through the code. cuda is imported only inside two functions
(exactly where I need it) when you use scan. So is it that the code that
generates the error actually uses scan, or this error happens even if you do
not use scan?

Razvan

On Fri, Oct 21, 2011 at 8:39 AM, Razvan Pascanu [email protected] wrote:

Yes I think so. This was introduced long long time ago. I've tried at one
point to fix it (before we moved to git) but it turned out not to be a
trivial task. I'll give it another go,
but know that this will not be done in a matter of minutes :(. Maybe I can
disable scan working on GPU for now removing the import (that should be
quick) and work on
repairing the damage afterwards.

Razvan

On Thu, Oct 20, 2011 at 8:53 PM, David Warde-Farley <
[email protected]>wrote:

Is this in theano stable as well?

Reply to this email directly or view it on GitHub:
#134 (comment)

Reply to this email directly or view it on GitHub:
#134 (comment)

from theano.

pascanur avatar pascanur commented on June 12, 2024

Hmm .. sorry for that. I somehow missed that import ( I import cuda also in
scan_op and scan_utils, but there only inside the functions that need it).
I've moved the import cuda inside the scan function. Hopefully this will
make things better for those who don't use scna.

I'll work on removing it completely, but I do not have a lot of time to
dedicate to Theano
unfortunately...

Razvan

On Fri, Oct 21, 2011 at 10:40 AM, James Bergstra <
[email protected]>wrote:

This seems straightforward, no?

  1. https://github.com/Theano/Theano/blob/master/theano/__init__.py#L80

https://github.com/Theano/Theano/blob/master/theano/scan_module/scan.py#L56

On Fri, Oct 21, 2011 at 10:35 AM, Razvan Pascanu
[email protected]
wrote:

I've looked through the code. cuda is imported only inside two functions
(exactly where I need it) when you use scan. So is it that the code that
generates the error actually uses scan, or this error happens even if you
do
not use scan?

Razvan

On Fri, Oct 21, 2011 at 8:39 AM, Razvan Pascanu [email protected]
wrote:

Yes I think so. This was introduced long long time ago. I've tried at
one
point to fix it (before we moved to git) but it turned out not to be a
trivial task. I'll give it another go,
but know that this will not be done in a matter of minutes :(. Maybe I
can
disable scan working on GPU for now removing the import (that should be
quick) and work on
repairing the damage afterwards.

Razvan

On Thu, Oct 20, 2011 at 8:53 PM, David Warde-Farley <
[email protected]>wrote:

Is this in theano stable as well?

Reply to this email directly or view it on GitHub:
#134 (comment)

Reply to this email directly or view it on GitHub:
#134 (comment)

Reply to this email directly or view it on GitHub:
#134 (comment)

from theano.

jaberg avatar jaberg commented on June 12, 2024

Thanks Razvan, just moving it out of the global import path is a good
enough for now I think. Put a comment next to the internal import
documenting why it isn't a global import, and that'd be fine by me.

  • James

On Fri, Oct 21, 2011 at 10:45 AM, Razvan Pascanu
[email protected]
wrote:

Hmm .. sorry for that. I somehow missed that import ( I import cuda also in
scan_op and scan_utils, but there only inside the functions that need it).
I've moved the import cuda inside the scan function. Hopefully this will
make things better for those who don't use scna.

I'll work on removing it completely, but I do not have a lot of time to
dedicate to Theano
unfortunately...

Razvan

On Fri, Oct 21, 2011 at 10:40 AM, James Bergstra <
[email protected]>wrote:

This seems straightforward, no?

  1. https://github.com/Theano/Theano/blob/master/theano/__init__.py#L80

https://github.com/Theano/Theano/blob/master/theano/scan_module/scan.py#L56

On Fri, Oct 21, 2011 at 10:35 AM, Razvan Pascanu
[email protected]
wrote:

I've looked through the code. cuda is imported only inside two functions
(exactly where I need it) when you use scan. So is it that the code that
generates the error actually uses scan, or this error happens even if you
do
not use scan?

Razvan

On Fri, Oct 21, 2011 at 8:39 AM, Razvan Pascanu [email protected]
wrote:

Yes I think so. This was introduced long long time ago. I've tried at
one
point to fix it (before we moved to git) but it turned out not to be a
trivial task. I'll give it another go,
but know that this will not be done in a matter of minutes :(. Maybe I
can
disable scan working on GPU for now removing the import (that should be
quick) and work on
repairing the damage afterwards.

Razvan

On Thu, Oct 20, 2011 at 8:53 PM, David Warde-Farley <
[email protected]>wrote:

Is this in theano stable as well?

Reply to this email directly or view it on GitHub:
#134 (comment)

Reply to this email directly or view it on GitHub:
#134 (comment)

Reply to this email directly or view it on GitHub:
#134 (comment)

Reply to this email directly or view it on GitHub:
#134 (comment)

from theano.

nouiz avatar nouiz commented on June 12, 2024

Just an idea to fix the problem, why not make gpu_hook in scan_module and have the import of cuda register fct in those hook?

Maybe there is better way to fix it, but this can work in all case I think and would solve the problem for people that use scan.

from theano.

dwf avatar dwf commented on June 12, 2024

Is this issue resolved by pull request #139? Can it be closed now?

from theano.

pascanur avatar pascanur commented on June 12, 2024

Just partially (as long as you do not use the scan op). So I think it
shouldn't be close just yet, because it can be solved in all cases with a
bit of care.

Razvan

On Mon, Oct 24, 2011 at 3:14 PM, David Warde-Farley <
[email protected]>wrote:

Is this issue resolved by pull request #139? Can it be closed now?

Reply to this email directly or view it on GitHub:
#134 (comment)

from theano.

lamblin avatar lamblin commented on June 12, 2024

Should we close it now?

from theano.

nouiz avatar nouiz commented on June 12, 2024

I think we can close it as now we should always be able to import cuda even if it isn't there. scan don't do it at import, so it is good I think.

from theano.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.