marvell-switch-tag differs from Linux DSA driver about tcpdump-htdocs HOT 3 CLOSED

On a related note, the code point for Policy Mirror was wrong (it is correct now).

from tcpdump-htdocs.

In tcpdump's print-dsa.c the comment and the macro indeed define the code as b18-b17-b12 (this seems to be one of the points discussed in pull request #13):

/*

 * Mode: Forward, To_CPU, From_CPU, To_Sniffer
 * b29: (Source or Target) IEEE Tag Mode
 * b18: Forward's Src_Is_Trunk, To_CPU's Code[2], To_Sniffer's Rx_Sniff
 * b17: To_CPU's Code[1]
 * b16: Original frame's CFI
 * b12: To_CPU's Code[0]
 */

#define DSA_CODE(tag) ((TOK(tag, 1, 0x06, 1) << 1) | TOK(tag, 2, 0x10, 4))

Besides that, a couple fields have different names in the two packet diagrams. @vivien, would you like to proof-read the HTML page and make it consistent?

from tcpdump-htdocs.

Alright, the fix is trivial, it has been made in commit 6e68a19, thank you for reporting this issue!

from tcpdump-htdocs.