Wrong key being passed to DataManager in Awards about the-blue-alliance-android HOT 5 CLOSED

Problem found. The awards list populator is setting the adapter keys to a
combination of the event key and the award name, not the team key like I
was expecting. I'll fix this later today.
On May 15, 2014 4:19 AM, "Bryce Matsuda" [email protected] wrote:

After pulling the latest master, I was doing my usual stress tests when I
hit an NPE crash whenever I tried viewing team info from the Awards tab,
which had never happened beforehand. Adding null checks didn't seem to
work, but then I noticed something odd in the title/header bar after a
couple of crashes.

[image: screenshot_2014-05-15-01-41-37]https://cloud.githubusercontent.com/assets/6787907/2982056/8d37be06-dc0f-11e3-9947-9252b53f3661.png

I checked logcat and found in each crash DataManager trying to load the
URL http://thebluealliance.com/api/v2/team/[award key] (e.g:
http://thebluealliance.com/api/v2/team/2014casb_Regional Chairman's Award)

Full logcat: http://pastebin.com/QfXU8yDE

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62
.

from the-blue-alliance-android.

Whoops. Wonder how I missed that one. I guess I should work on tests today
On May 15, 2014 8:14 AM, "Nathan Walters" [email protected] wrote:

Problem found. The awards list populator is setting the adapter keys to a
combination of the event key and the award name, not the team key like I
was expecting. I'll fix this later today.
On May 15, 2014 4:19 AM, "Bryce Matsuda" [email protected]
wrote:

After pulling the latest master, I was doing my usual stress tests when
I
hit an NPE crash whenever I tried viewing team info from the Awards tab,
which had never happened beforehand. Adding null checks didn't seem to
work, but then I noticed something odd in the title/header bar after a
couple of crashes.

[image: screenshot_2014-05-15-01-41-37]<
https://cloud.githubusercontent.com/assets/6787907/2982056/8d37be06-dc0f-11e3-9947-9252b53f3661.png>

I checked logcat and found in each crash DataManager trying to load the
URL http://thebluealliance.com/api/v2/team/[award key] (e.g:
http://thebluealliance.com/api/v2/team/2014casb_Regional Chairman's
Award)

Full logcat: http://pastebin.com/QfXU8yDE

—
Reply to this email directly or view it on GitHub<
https://github.com/the-blue-alliance/the-blue-alliance-android/issues/62>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-43201841
.

from the-blue-alliance-android.

Wait - there isn't always a team key associated with an award (some, like Volunteer of the Year, aren't associated with teams). Do we want to rely on something like that for a key?

The way TBA does handles award keys is <event-key>_<award-enum>. I think we should do it this way as well, but the enum isn't exposed to the API (forgot about those when I added it). I'll add it in though.

from the-blue-alliance-android.

Volunteer of the year wouldn't have to react to a click because there's no
associated team to display. In that case, just set the key to an empty
string and check for that in the click listener. Afaik the only place we
use keys is the click listener so that should be safe.
On May 15, 2014 11:29 AM, "Phil Lopreiato" [email protected] wrote:

Wait - there isn't always a team key associated with an award (some, like
Volunteer of the Year, aren't associated with teams). Do we want to rely on
something like that for a key?

The way TBA does handles award keys is _. I think we should do it this way
as well, but the enum isn't exposed to the API (forgot about those when I
added it). I'll add it in though.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-43232843
.

from the-blue-alliance-android.

Ah, you're right. That's a good point. Just the team key should be fine,
then

On Thu, May 15, 2014 at 12:33 PM, Nathan Walters
[email protected]:

Volunteer of the year wouldn't have to react to a click because there's no
associated team to display. In that case, just set the key to an empty
string and check for that in the click listener. Afaik the only place we
use keys is the click listener so that should be safe.
On May 15, 2014 11:29 AM, "Phil Lopreiato" [email protected]
wrote:

Wait - there isn't always a team key associated with an award (some,
like
Volunteer of the Year, aren't associated with teams). Do we want to rely
on
something like that for a key?

The way TBA does handles award keys is _. I think we should do it this
way
as well, but the enum isn't exposed to the API (forgot about those when
I
added it). I'll add it in though.

—
Reply to this email directly or view it on GitHub<
https://github.com/the-blue-alliance/the-blue-alliance-android/issues/62#issuecomment-43232843>

.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-43233334
.

from the-blue-alliance-android.