Git Product home page Git Product logo

Comments (5)

nwalters512 avatar nwalters512 commented on June 5, 2024

It looks like we never check if the view is null on onPostExecute(...) in most of our populating AsynkTasks. There are two ways to fix this: we could either check if the view is null before trying to access it, or store a reference to each instance of a Populator task we create and calling cancel(...) in onDestroyView() of the hosting fragment.

from the-blue-alliance-android.

phil-lopreiato avatar phil-lopreiato commented on June 5, 2024

Yeah, that makes sense. In the onPostExecute, you can just add a null check
on the LinearLayout.
Or check if the fragment is still active or something.

from the-blue-alliance-android.

brycematsuda avatar brycematsuda commented on June 5, 2024

Ooh null checks, my favorites.

Went through most of the Populate classes and added null checks. Looks good for now. Pull request to come soon.

from the-blue-alliance-android.

nwalters512 avatar nwalters512 commented on June 5, 2024

Sounds good! Thanks for doing all this stress-testing by the way, this is
stuff we probably wouldn't have found with normal usage.
On May 8, 2014 10:50 PM, "Bryce Matsuda" [email protected] wrote:

Ooh null checks, my favorites.

Went through most of the Populate classes and added null checks. Looks
good for now. Pull request to come soon.


Reply to this email directly or view it on GitHubhttps://github.com//issues/42#issuecomment-42631114
.

from the-blue-alliance-android.

brycematsuda avatar brycematsuda commented on June 5, 2024

No problem! Happy to help out in any way possible.

from the-blue-alliance-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.