Comments (5)
It looks like we never check if the view is null on onPostExecute(...)
in most of our populating AsynkTasks. There are two ways to fix this: we could either check if the view is null before trying to access it, or store a reference to each instance of a Populator task we create and calling cancel(...)
in onDestroyView()
of the hosting fragment.
from the-blue-alliance-android.
Yeah, that makes sense. In the onPostExecute, you can just add a null check
on the LinearLayout.
Or check if the fragment is still active or something.
from the-blue-alliance-android.
Ooh null checks, my favorites.
Went through most of the Populate classes and added null checks. Looks good for now. Pull request to come soon.
from the-blue-alliance-android.
Sounds good! Thanks for doing all this stress-testing by the way, this is
stuff we probably wouldn't have found with normal usage.
On May 8, 2014 10:50 PM, "Bryce Matsuda" [email protected] wrote:
Ooh null checks, my favorites.
Went through most of the Populate classes and added null checks. Looks
good for now. Pull request to come soon.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/42#issuecomment-42631114
.
from the-blue-alliance-android.
No problem! Happy to help out in any way possible.
from the-blue-alliance-android.
Related Issues (20)
- App switches to dark theme after opening settings
- Week 1 events tab displays as "Preseason Events"
- Event codes with numbers have numbers stripped from notification titles HOT 3
- Performance improvement suggestion
- Unable to download data HOT 5
- Android app icon guidelines have changed HOT 1
- If a match is delayed, the match time isn't updated HOT 1
- CCWM calculations are flawed
- Stuck on welcome screen (BETA) HOT 5
- Setup not persisting HOT 2
- Errors on Notifications on Android S+
- Team@Event Clicks Are Wonky
- Notifications Have Empty Icons on Some Devices HOT 2
- Button to cache available team avatars
- No offseason Events HOT 1
- 16 x "Team 971 CC Q44 Results" notifications, 14 x "[Team 971] CC Q11 Results", ... 108 total HOT 4
- App can not open a website links HOT 2
- [2023] Updates for Double Elims
- Match times are different for Android vs Apple HOT 1
- [BUG] Event selection not going to the correct event HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from the-blue-alliance-android.