Comments (8)
Is that actually true? As far as I can tell from code, this only hits all blocks' index files which are already preloaded on store node, right?
If that's so, we can close this issue. (:
from thanos.
Yes, but we are still considering not caching those full files right? My thinking was even with, we could be talking about tens of thousands of blocks at some point. And that might still get expensive then.
We also always have to do a full fanout to every single Prometheus server.
But you are generally right, this issue was probably opened as a pre-mature concern.
from thanos.
Ah, sorry, you're right. We will soon move out from this preload-all-index-files heaven.
from thanos.
Mh, I'll close this for now. On store nodes that data is served entirely from memory now anyway. The full fanout is probably not an issue anymore with that.
from thanos.
We are exploring loading blocks on demand, so it's time to reopen this as values would be no longer in memory. (:
Worth to note that mostly __name__
arg is heavily used, so we might want to cache all of it. Not sure if worth on Querier side.
The alternative would be implementing the time limit on this. Also related to the: prometheus/prometheus#6178
from thanos.
The alternative would be implementing the time limit on this. Also related to the: #39
couldn't help noticing this issue is related to itself, surely a mistake :)
from thanos.
yup, fixed!
from thanos.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from thanos.
Related Issues (20)
- increase/rate got abnormally large result on aggregated data sources HOT 6
- Index header creation is not windows compatible HOT 2
- Constant compactor warnings due to deletion delay HOT 3
- Thanos Compactor not pruning old data HOT 2
- S3 bucket Access Denied when retrieving credentials using Amazon EKS Pod Identity HOT 4
- Add a source label to the `thanos_rule_evaluation_with_warnings_total` metric
- Is Thanos FIPS compliant? HOT 2
- Thanos receiver is unable to ingest data stating msg="only metadata from client; metadata ingestion not supported skipping” HOT 1
- receive: Issue with hashring configuration leading to "amount of endpoints needs to be larger than replication factor" error HOT 1
- Dedup Index Cache requests HOT 1
- Dedup ExpandPostings call
- receive-distributor: SIGSEGV and workbuf is not empty HOT 6
- alert for `receive` not uploading triggers on empty block writes
- Thanos generates a lot of warnings when Prometheus creates empty chunks
- [Compact] duplicated blocks with different id but same data
- Support random delay before upload blocks on sidecar HOT 2
- Thanos compactor shutting down do to timeout whilest trying to get no-compact-mark.json
- Thanos receiver query frontend returns "Can't read from closed head" error
- compact: once it run out of disk space, it keeps running but is still broken HOT 7
- compact: if compaction didn't run for a while, it seems to need more and more local disk space HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thanos.