Compile errors on Release about sc HOT 7 CLOSED

I should've written "closes" I guess :)

from sc.

I should've written "closes" I guess :)

Yes or you could set Linked pull requests in the menu on the right 🤖

from sc.

If I change these lines
if (NOT CMAKE_C_COMPILER_ID MATCHES "MSVC")

To this:
if (NOT CMAKE_C_COMPILER_ID MATCHES "MSVC" AND SC_BUILD_TEST)

I can disable this behavior from my build, but this is a good solution?

from sc.

We shouldn't build tests in release mode because libs won't be testable thoroughly without some tricks compiler provides in debug mode. e.g testing return value of malloc, system calls etc.

How about something like this : https://github.com/tezc/sc/pull/45/files.
Here we build tests only on Debug build.

I didn't expect anybody use my messy cmakefiles, all started from it, sorry about that :)
We have some tests for release mode actually that we use in our projects but I need to clean them up and then merge to this repo. It may take some time though.

from sc.

Thanks for the super-duper fast response and sorry for not making the intended use of your repo! 😬

Is looking good, just made a comment about a still going warning on sc_thread.c, besides that, is looking good!

from sc.

Mind making a new release?

from sc.

Done : https://github.com/tezc/sc/releases/tag/v1.0.1

from sc.