Can't turn off flash on android about react-native-camera-kit HOT 16 CLOSED

@gran33 sorry wrong issue.

from react-native-camera-kit.

@gran33 so you can do something like that:

<CameraKitCamera
      ref={(cam) => {
        window.camera = cam;
      }}
      style={{
        width: Dimensions.get('window').width,
        height: Dimensions.get('window').width
      }}
      cameraOptions={{
        flashMode: 'off',             // on/off/auto(default)
        focusMode: 'on',               // off/on(default)
        zoomMode: 'on',                // off/on(default)
        ratioOverlay: '1:1',            // optional, ratio overlay on the camera and crop the image seamlessly
        ratioOverlayColor: '#00000077' // optional
      }}
    />

if you on your iphone try to make a photo on very black background (put your phone on a desk for example), it uses the flash.

I think a fix could be the following:

In CKCamera.m you are using

            [CKCamera setFlashMode:AVCaptureFlashModeAuto forDevice:self.videoDeviceInput.device];

instead you should be using

            [CKCamera setFlashMode:self.flashMode forDevice:self.videoDeviceInput.device];

from react-native-camera-kit.

@faisalkanji did u try on a real device?

from react-native-camera-kit.

Hi @gran33 yes I tried it on a real device

from react-native-camera-kit.

And? I tried it as well, and seems to work fine.
U r trying to take a photo without flash, right?

from react-native-camera-kit.

from react-native-camera-kit.

I have the same issue even on ios

from react-native-camera-kit.

@philolo1 Can u please explain how to reproduce?

from react-native-camera-kit.

Good news, thanks.
Did u check on Android or iOS?

from react-native-camera-kit.

@philolo1 Does it reproduce after u flip from back camera -> front -> back?

from react-native-camera-kit.

@gran33 you mean in the not modified code? Yes its the same issue, because there is also some code that sets it to automode, instead of the mode it is currently in. I would also expect it to be be the same mode as the other camera.

from react-native-camera-kit.

@philolo1 Thanks for everything! I fixed that and published to npm (fixed iOS only). See here:
f7260eb

@yedidyak can u please take a look on Android?

from react-native-camera-kit.

[Android Only] Can confirm this happening in react-native-camera-kit V6.2.4

from react-native-camera-kit.

Hi, i am having the same issue in react-native-camera-kit V8.0.4, in android i have the code below
<CameraKitCamera
ref={cam => this.camera = cam}
style={styles.camera}
cameraOptions={{
flashMode: 'off',
focusMode: 'off',
zoomMode: 'off',
}}
/>

and the flash is in mode 'auto' when use the camera.

from react-native-camera-kit.

Hello, any update on this ?? also using react-native-camera-kit V8.0.4

from react-native-camera-kit.

The android part of the library will be rewritten using Google's new CameraX library. This should solve some of the issues, or at least have a capable party finding bugs :)

from react-native-camera-kit.