Modify the structure of 3d visualization code about lfda HOT 5 CLOSED

@zachmayer I added unit test for the plotting but it looks like in Travis it cannot open the plotting device. Error: RGL: unable to open X11 display in this build https://travis-ci.org/terrytangyuan/lfda/builds/75081008

Do you have any idea to get around with this?

from lfda.

https://cran.r-project.org/web/packages/rgl/index.html

Check the "system requirements" page:
SystemRequirements: OpenGL, GLU Library, zlib (optional), libpng (>=1.2.9, optional), FreeType (optional)

You also need X11. You need to run something like this (from the travis help page):

before_install:
    - sudo apt-get update -qq
    - sudo apt-get install -qq freeglut3-dev xorg openbox

freeglut3-dev will install openGL and GLU, the other 2 will install X11.

from lfda.

(btw, this is why we don't want caret to depend on rgl— it's a lot of effort to get installed)

from lfda.

Hmm I couldn't get it to work by adding before_install in Travis and options(rgl.useNULL=TRUE) in the plotting code. The code work fine by devtools::test() and devtools::check() though on my PC. Would this be enough for CRAN submission? Are they looking at my Travis build?

from lfda.

CRAN will be checking on a machine very much like the travis machine. It won't have an rgl environment setup.

from lfda.