Git Product home page Git Product logo

Comments (3)

terriko avatar terriko commented on June 15, 2024

Note: this is partially fixed by #34, which disallows negative numbers. We should still check for increase_number > starting_count and print an error.

(Yes, you could use double-increases, but I think it's rare that you'd want them in a sleeve because they tend to leave holes, so an error message so that folk double-check their numbers is likely more useful to the average user.)

from pyknit.

Ben-Hampson avatar Ben-Hampson commented on June 15, 2024

I've added the errors that my non-knitting mind can think of. Let me know if there are some more to add.

I wonder if we should raise Exceptions instead? Currently a message is printed and the function carries on as normal. Also, if we had Exceptions we could also test for those scenarios.

from pyknit.

terriko avatar terriko commented on June 15, 2024

I filed an issue #38 about converting the errors to something that isn't a print statement. I'm probably not going to get to it until next week at the earliest, though!

from pyknit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.