Git Product home page Git Product logo

Comments (7)

Prospector avatar Prospector commented on July 23, 2024

Where are your buttons supposed to be/where are they without mod menu installed?

from modmenu.

Sollace avatar Sollace commented on July 23, 2024

Here's a side-by-side comparison.
image

This is patched in an update to the mods, just by setting the y position again after adding them.

private void onScreenInit(Screen screen, ScreenInitCallback.ButtonList buttons) {
    if (screen instanceof TitleScreen) {
        Button button = buttons.add(new Button(screen.width - 50, screen.height - 50, 20, 20));
        ...
        button.y = screen.height - 50; // ModMenu;
    }
}

But I shouldn't have to do this just to keep my buttons from being messed with.

from modmenu.

Prospector avatar Prospector commented on July 23, 2024

This is intentional, it is meant to ensure the place you lined your buttons up with is consistent when you install Mod Menu... quite frankly I didn't anticipate anyone who decided not to line their buttons up with one of the other buttons... (ie. a button next to the Realms button will be next to it with Mod Menu installed). As you can see, the buttons maintains the horizontal alignment it had with the Realms and Quit Game buttons.

from modmenu.

Sollace avatar Sollace commented on July 23, 2024

Ooo...kay.

A bit of a strange decision. It has this weird effect that causes buttons to have an extra gap between them, and messes with any arrangement that depends on the buttons keeping the positioning they were intended to have.

imo. You should rather work on a solution that doesn't end up offsetting the entire Title Screen. (hate to say, Forge had the right idea on something for once)

from modmenu.

Prospector avatar Prospector commented on July 23, 2024

personally, I find it strange that you would have buttons that don't align at all with the current buttons on the screen

from modmenu.

Sollace avatar Sollace commented on July 23, 2024

That's because they're designed to align with the bottom-right corner. They're not intended to be the centre of attention like that. Though you do have a point, I've at times found myself looking at how the pants button doesn't quite align with the bottom set of buttons and thought it looked strange.

But when you resize the game window and make it larger, you realise it would look a whole lot weirder to have ot float up next to the regular buttons instead.

from modmenu.

Prospector avatar Prospector commented on July 23, 2024

I think I'm gonna go ahead and say no to fixing this, because I think the benefit of aligned buttons staying in their positions relative to other buttons vastly outweighs the very niche case of intentionally misaligned buttons (never seen anyone other than you do this). I may, however, consider altering how the buttons are moved...maybe only if they're aligned with a button or a blacklist or something.

from modmenu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.