Git Product home page Git Product logo

Comments (2)

eerkunt avatar eerkunt commented on May 24, 2024 1

Hi!

It might be problematic since "public facing" is something hard to decide. So you need to be careful while setting up this rule, since you might have some "public facing" AWS Resources ( like ELB/ALB/NLB ) and "vpc internal" ones. So checking for all security groups and checking for no "ingress" port would be a problem. Since internal ones will have and they need to pass.

Thus, first you need to identify which security group/aws resource will be public.

I need to check a bit deeper, we might create a BDD test where ;

  • Among all the (for e.g.) ELBs, find the ones with Public IP
  • Find the Security Groups are used. - not sure about this capability right now, since there is a resource mounting but not sure if it is working for SG -> Resource. Need to check.
  • Within that SG, check if there is any Ingress rules defined.

This might require some changes within terraform-compliance like in resource mounting and some enhancements might require to be implemented ( like storing a resource with a custom name that can be used by other tests/scenarios within the same Feature ).

from cli.

eerkunt avatar eerkunt commented on May 24, 2024

There is a workaround introduced with #73, state storing defined in #69 will be in next releases.

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.