Git Product home page Git Product logo

Comments (7)

eerkunt avatar eerkunt commented on May 24, 2024

Is it possible to share plan.out.json for debugging, if it is not confidential ?

from cli.

anthonycolon25 avatar anthonycolon25 commented on May 24, 2024

Here you go. One question that comes to mind is are aws_launch_configuration resources still valid in 0.12+? Should it be aws_launch_template?
plan.out.json.txt

from cli.

eerkunt avatar eerkunt commented on May 24, 2024

Thanks! It looks like the problem is there due to resource mounting.

Will create a fix asap.

from cli.

anthonycolon25 avatar anthonycolon25 commented on May 24, 2024

What is resource mounting?

from cli.

eerkunt avatar eerkunt commented on May 24, 2024

This is a feature of terraform-compliance to comply with deeper tests created with terraform.

E.g. ;

resource "aws_security_group" "my_security_group" {
  name        = "some-sg"
  ...
}

resource "aws_security_group_rule" "my_security_rule_1" {
  type                     = "ingress"
  from_port                = 443
  to_port                  = 443
  protocol                 = "tcp"
  ...
  ...
  security_group_id        = "${aws_security_group.security_group.id}"
}

Where aws_security_group_rule.my_security_rule_1 is actually mounted on aws_security_group.my_security_group - which means, when terraform-compliance runs a test against aws_security_group.my_security_group, it should also check all the mounted resources against that resource.

Specifically, the bug in your scenario was, aws_autoscaling_group.example (which supports tags) was mounted over aws_launch_configuration.example and when we search for the tags within the values, it was returning True.

Now it is fixed with 1.0.8, please have a try :)

from cli.

anthonycolon25 avatar anthonycolon25 commented on May 24, 2024

Tested with 1.0.8. it looks good. It is no longer failing for missing aws_launch_configuration tags.

Thanks.

from cli.

eerkunt avatar eerkunt commented on May 24, 2024

Thanks for re-testing. Closing the issue.

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.