Setting create_origin_access_identity to true does not enable OAI on distribution about terraform-aws-cloudfront HOT 5 CLOSED

After messing around a bit with the module itself, I've found that changing origin.value to var.origin in dynamic "s3_origin_config" makes it work like it should.

dynamic "s3_origin_config" {
        for_each = length(keys(lookup(var.origin, "s3_origin_config", {}))) == 0 ? [] : [lookup(var.origin, "s3_origin_config", {})]

However, I don't know if this is an actual fix or a dirty workaround.

I also noticed that I use the origin like this:

  origin = {
    s3_origin_config = {
      domain_name = var.aws_s3_url
      origin_access_identity = "s3_bucket_one" # key in `origin_access_identities`
      cloudfront_access_identity_path = var.aws_cloudfront_use_oai ? "origin-access-identity/cloudfront/ABX123" : null
    }
  }

when it should actually be used like this:

  origin = {
    first_origin = {
      domain_name = var.aws_s3_url
      s3_origin_config = {
        origin_access_identity = "s3_bucket_one"
        cloudfront_access_identity_path = var.aws_cloudfront_use_oai ? "origin-access-identity/cloudfront/ABC123" : null
      }
    }
  }

but this gives me super vague errors on some parameters I'm apparently not setting, which I remember I had a very had time solving when I started using this module:

The argument "origin.0.s3_origin_config.0.origin_access_identity" is
required, but no definition was found.

from terraform-aws-cloudfront.

FYI, I moved away from this module due to this issue, so this isn't urgent anymore to me personally, although I'm still curious to know what I did wrong.

from terraform-aws-cloudfront.

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

from terraform-aws-cloudfront.

This issue was automatically closed because of stale in 10 days

from terraform-aws-cloudfront.

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

from terraform-aws-cloudfront.