Git Product home page Git Product logo

Comments (9)

iamssen avatar iamssen commented on August 15, 2024 2

Started adding sign() feature. You can refer to this PR(#7).

We need to add features to the Mobile App, so it will take some time for the full release.

For now, you can test it based on Chrome Extension.

from wallet-provider.

iamssen avatar iamssen commented on August 15, 2024

@Mskalba Sorry, the sign feature is not yet implemented for Terra Station Mobile and @terra-money/wallet-provider.

I am currently developing another service, so it will take time to implement the sign function. I will let you know again when the function is implemented.

from wallet-provider.

tkowalczyk avatar tkowalczyk commented on August 15, 2024

@iamssen thank you for quick update, I am working with @Mskalba we have also tried some workarounds but without results as you might see here: terra-money/terra.js#95, could you maybe provide some ETA for this feature?

from wallet-provider.

iamssen avatar iamssen commented on August 15, 2024

@tkowalczyk I'm sorry. I have a lot of things to develop, so it will be difficult to start development for this quickly.

I will discuss the development schedule for this part with the team.

from wallet-provider.

tkowalczyk avatar tkowalczyk commented on August 15, 2024

fully understand, would be great if you will provide later some ETA, good luck!

from wallet-provider.

cryptoethic avatar cryptoethic commented on August 15, 2024

Hi!

As you have a lot of things in your pipeline, @iamssen, I would like to ask if you could utilize any help with this feature.
If you could point out which libraries require changes so I could focus on extending them to provide such functionality.

As far as I understand signMessage is not exported by useWallet, because it lacks implementation in Wallets (Terra Station Mobile only?)

Please let me know if you could give me some hints. What is missing in current version and where to look for it so I could have easier start with working on that ;)

from wallet-provider.

iamssen avatar iamssen commented on August 15, 2024

We discussed and decided not to implement the sign() function in wallet-provider.

In the case of Extension, the sign() function is not a big threat because it is only within the user device, but sending a signed key through the walletconnect bridge server is considered a security concern.

from wallet-provider.

cryptoethic avatar cryptoethic commented on August 15, 2024

Oh, this is definitively a bad news.

Could I ask what dangers are introduced when we send signed transaction over walletconnect bridge? And how far it is different from creating a signed transaction via walletconnect and broadcasting it to the network.

I might be asking basic questions but I'm new to terra ecosystem and would love to gain as much knowledge as possible ;)

from wallet-provider.

alex-ald avatar alex-ald commented on August 15, 2024

Hi, I would love to hear the answers to the above question as well!

from wallet-provider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.