Comments (3)
For people wanting to contribute, this appears to still be an open bug. There is an existing dummy method called isPawnDropMate(ShogiBoardState, Square) that can be found in PawnMovement.java. It seems like it would only have to make a call to isPositionCheckmate(ShogiPosition, boolean) from ShogiRulesEngine.java.
Edit: Nevermind, see below comment...
from playshogi.
Ah! I just noticed that the logic was implemented in a recent commit by Tellmarch: Tellmarch/playshogi:@ca3385a0371b3ac626bffdb09c07021eab4262d2
The logic is contained within the GameNavigator. This means that the PawnMovement's isPawnDropMate() method may be unnecessary and is a good candidate for removal during a refactor.
from playshogi.
I am adding a JUnit test to verify the functionality. I do not see logic contained inside GameNavigation.java.
https://github.com/Tellmarch/playshogi/runs/964332349?check_suite_focus=true#step:6:249
from playshogi.
Related Issues (20)
- Feature Request: Ability to comment on problems. HOT 1
- Add an option to use "international" pieces HOT 1
- Feature Request: Ability to export the initial position from TsumeView mode in SFEN format. HOT 1
- Bad Problems: Koma Amari mainline, unintended alternate solutions, unaccepted valid alternate lines, etc.
- High-resolution graphics (zoom)
- Show coordinates on board
- Upgrade to GWT 2.9 HOT 3
- [Maybe] Make the website internationalizable
- Tsume: Why is my move incorrect? HOT 1
- Add a link to Tsume problem rules HOT 1
- In the "Tell me why" button have a text for a longer solution
- Guess The Move
- Allow piece deselection HOT 1
- Promotion puzzles
- Possibility to merge several Game collections
- Add username validation HOT 1
- Pray to Nifu Gods
- Puzzle promotion popup (international)
- Readme
- Move sounds HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from playshogi.