Comments (11)
This is the design doc for both templating and references, shared with members of knative-dev@.
from pipeline.
/assign @dlorenc
/meow space
from pipeline.
In response to this:
/assign @dlorenc
/meow space
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from pipeline.
@bobcatfish should this issue be closed? I think its done now by the above PRs
from pipeline.
I think that actually templating with a Task's outputs still isn't implemented 🤔 But i think @dlorenc has a branch with this fixed so we can nearly close this...
from pipeline.
The other thing still missing is applying any templating at a Pipeline level.
from pipeline.
Can this be closed now?
from pipeline.
Only use case left is when you provide templating via a Pipeline:
kind: Pipeline
...
- name: deploy-bundle-test
taskRef:
name: deploy-with-kubectl
inputSourceBindings:
- name: workspace
key: guestbook
- name: myImage
key: redis-docker
passedConstraint:
- build-push
params:
- name: labels
value: "${myImage.digest}@${workspace.revision}"
In the end the value
should be expanded
from pipeline.
So I'm not 100% sure of the best way to test this. I added a test case to show that the PipelineRun reconciler does not expand these and will pass them to the TaskRun controller, and we have TaskRun tests that show they get expanded. But that doesn't feel very satisifying...
from pipeline.
At first glance, at least, that sounds like a reasonable set of tests to me.
from pipeline.
I added a test case to show that the PipelineRun reconciler does not expand these and will pass them to the TaskRun controller, and we have TaskRun tests that show they get expanded. But that doesn't feel very satisifying...
I hear you! I can't think of anything better at the moment - we could have an integration tests that passes the whole thing in and makes sure the right thing comes out, but that sounds pretty rough.
I was looking at some of the kubebuilder stuff today with @pwittrock and the integration tests it generates, which can instantiate the controllers and api server locally, could be an interesting way to test something like this.
That being said it kinda feels like overkill!
TL;DR: @dlorenc I think either add the test you've described or just decide it's not worth covering and leave it as is.
from pipeline.
Related Issues (20)
- Additional unit tests are needed for Kubernetes native sidecar support HOT 2
- Remote resolvers fail to save ECR cache
- The spec fields of TaskRun and PipelineRun can still be modified during execution
- Allow modify the spec of a PipelineRun when it is in the `PipelineRunPending` state
- A mechanism to remotely obtain runtime parameters of `TaskRun` and `PipelineRun` HOT 4
- Add support for `when` within `matrix.include`. HOT 3
- It is not possible to have the webhook controller _not_ use TLS HOT 1
- No variable substitution when using matrix and array the length of 1
- pipelinerun-with-when-expressions HOT 2
- TaskRun pod should have UUID label of Taskrun HOT 1
- The TaskRun did not fail promptly after the Pod experienced OOM
- Cancelling an active PipelineRun with TaskRuns that are already complete hits "PipelineRunCouldntCancel" condition on v0.62.0 HOT 1
- Enable securityContext field for affinityassistant podtemplate
- pprof profiling does not work with tekton-pipelines-controller deployment HOT 2
- Set container level securityContext for Affinity assistant HOT 1
- Add new feature flag to set readOnlyRootFilesystem for pipelinerun, taskrun and Affinity assistants containers HOT 1
- default resource requirements should be executed before LimitRange transformer HOT 1
- Install Tekton Pipelines HOT 4
- Support OCI VolumeSource
- Ability to add `serviceAccountName` per task in `pipeline` HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pipeline.