Comments (5)
@jessm12 Sorry I had not seen your comment sooner! Yeah, I was told on our review yesterday that you can only filter the PLRs by label. So it wouldn't make any sense to have "label" in the dropdown.
@ncskier informed me that the following are the possible labels:
"app": "tekton-webhook-handler",
"gitServer": "github.com",
"gitOrg": "tektoncd",
"gitRepo": "pipeline",
"gitBranch": "master",
So, maybe we could work the dropdown that way??
To answer your first question, YES, the intention would be to do a lookup on all PLRs with similar matches to what the user has typed. So, yes, that could be a computational load.
However, the dropdown would only show (say for example) the first 4 matches that are most similar to what the user just typed. So, it wouldn't use all the real estate in the dropdown.
To see a similar example, go to W3 and use that filter. You'll see it divides the results into categories. I can select from the options in the dropdown or just hit enter and load everything.
That's the pattern I was copying.
Yes, I agree with you. I love the idea of using the key:value pairs. We need your technical expertise on how to surface that in the UI. I just don't know how they work, but I guess it's similar to the labels Brandon sent above.
from dashboard.
@skaegi That will baked into the visual design. We'll be using components from the IBM Design Language (carbon).
from dashboard.
Working on this user flow. Would love feedback:
Typing state. User can press enter or select from the dropdown:
from dashboard.
Thanks for these designs @kimholmes! πThe current implementation that I have is filtering only on label (labelKey:labelValue) and there is no dropdown functionality. I think the dropdown could be a great enhancement to add to the filtering down the line.
One question I do have is would the intention be to populate these filters in the dropdown by doing a lookup on all Pipeline Runs to find all of the labels that are on them for example? A thought I would have there is that if you have hundreds of them this could be a lot of additional computation and there could be a large amount of matches that may overwhelm the space within the dropdown and that may well slow things down depending on your network/cluster.
Also, generally I think the filters would be in the form of key:value pairs so branch:master
or name:tekton
though there could be scope where we could accept some singular values if we are searching across multiple fields perhaps but it should probably be something as standardised as possible. I think this could definitely use further discussion over the design and technical considerations π
from dashboard.
Basic label-based filtering implemented. No current plan to add the more advanced filter dropdown from the designs above although we can revisit in future if we change how we're using the Kubernetes APIs to give us more flexibility in this area.
from dashboard.
Related Issues (20)
- Pass timeframe to external-logs service HOT 1
- Have Pipelines and Tasks sections also display definitions from remote resolvers, such as git, etc HOT 2
- Google storage has not been updated with latest 0.36.1 release HOT 1
- The `apiVersion` displayed in the dashboard does not match the `apiVersion` used HOT 2
- ACTION REQUIRED: Changes to pulling Chainguard Images HOT 4
- Tekton windows localhost OAuth setup failed HOT 12
- [Translation] Support more languages HOT 4
- Namespace selector keeps jumping back to first alphabetically HOT 10
- Tekton Rebuild - 403 denied HOT 1
- Dashboard allows drop down of tasks/pipleines, can we have multi-select also to choose multi tasks/pipelines to trigger a Run. HOT 10
- Need to add an indication (tekton chains logo) when a task is signed by tekton chains for taskRuns HOT 1
- Add the ability to select a pipeline/task from a dropdown list and optionally make it mandatory HOT 3
- Admission Controller refuses PipelineRun created using Tekton Dashboard HOT 4
- Ability to select an initial namespace on GUI HOT 13
- Add more rendering options in pipelineRun generatedName HOT 3
- Improve layout on smaller screens HOT 2
- Add StepActions to the Dashboard HOT 8
- How to configure tekton dashboard pod log outputPath HOT 1
- Add ability to disable links to resource details pages on a resource extension list page HOT 6
- Add "Toggle Wrap" in Logs viewer HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dashboard.