DashboardController.groovy crashes when not using a product (e.g. RDS) about ice HOT 5 CLOSED

@cjbehm can you provide detailed steps on how to reproduce this issue? Did you have your own ResourceService subclass? Did you already created some application groups?

from ice.

You could probably recreate the experience by picking a Product and forcing getTagGroupManager() to return null for it. If you wanted to simulate specifically what I experienced, have getTagGroupManager return null when product == RDS. I had done a git pull (to get the sample resource service and changes).

I'm using the sample resource service, modified so that it uses the resourceId for everything. Purely basic to see it in action and get a sense for using it.

Before my hack, I couldn't create any Application Groups since the page would not load the entire form. It would show the name & email boxes as well as the Save (deactivated) and Cancel buttons. And of course output the null object error on the console.

From there I added a logger line and had it output product.toString() which is where I saw the RDS show up and figured that it had something to do with not using the product.

After wrapping that block of code in a try/catch to ignore empty products, the page loaded successfully and I was able to create an Application Group. I'm sure that's just a hack to fix the symptom and not the cause.

(Issue #15 was holding me up from actually seeing content on the By Application Group page, but I worked around that too)

from ice.

@cjbehm I checked in the code the for cases when product returned by ResourceService does not exist. Please pull the latest code and try again.

On the side note, returning resource id as the resource group name may slow down your program significantly if you have many distinct volume ids and instance ids etc.

from ice.

That appears to fix the Create New Application Group page. I'll comment on the "By Application Group" page in the other issue to keep them separate.

from ice.

Closing this issue since it's been fixed

from ice.