Comments (4)
Yeah its a warning emitted by boost somewhere iirc (probably asio for the socket code). It wants to know what windows version (and crucially what features) we have. See the msdn docs on the matter. I'm not sure if there is an advantage to having a version higher than 7 when using asio, and I couldn't find anything in the docs (although they are pretty sparse).
I think malloy should probably offer a cmake option for this, since we can't really make decisions about what windows version the user has (or wants to expose) for them. It could cause issues though if the package is built with a version separate from the version used by the user when including the headers, if asio does things like change class layouts based on it for example.
I suggest we add an option which defaults to 0x0A00
(windows 10) and use it define _WIN32_WINNT
. imo this should be a public define so users can't accidentally build with possibly conflicting versions.
from malloy.
Interesting. Gotta love Windows :p
As far as I can tell it is indeed a good idea to have a cmake
option for this with defaulting to 0xA00
.
from malloy.
Currently working on this. After setting _WIN32_WINNT
to 0xA00
the MSVC CI now fails with:
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winuser.h(4379): error C2061: syntax error: identifier 'LPWNDCLASSEXA'
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winuser.h(4387): error C2061: syntax error: identifier 'LPWNDCLASSEXW'
D:\a\malloy\malloy\3rdparty\boost-1.74.0\boost/asio/detail/impl/win_thread.ipp(54): error C2039: 'QueueUserAPC': is not a member of '`global namespace''
D:\a\malloy\malloy\3rdparty\boost-1.74.0\boost/asio/detail/impl/win_thread.ipp(54): error C3861: 'QueueUserAPC': identifier not found
from malloy.
Fixed in 49a7f7d
from malloy.
Related Issues (20)
- Usage of start() HOT 9
- Client: SNI hostname on WSS connection
- HTTP: More centralized configuration
- Connection timeout configuration
- Cross-Platform Way to Get Root Certs From Store? HOT 4
- server::listener: provide method for catching binding errors
- HTML form: check for requires fields HOT 2
- HTTP server: Add cache control HOT 1
- HTML form: populate() potentially dangerous HOT 1
- Custom HTTP response generator
- controller i/o threads reservation
- Form parsing should honor Content-Type
- Deprecate HTML namespace
- Generator response types HOT 1
- CMake: Check Windows 11 implementation for get_WIN32_WINNT
- HTTP Client: Allow connection re-use
- Potential issue in session cookie handling
- HTTP: Improve cookie handling
- HTTP connection detector: Different logging styles
- Consider using Botan for host certificate store access HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from malloy.