Possible bug with sending binary data about malloy HOT 2 CLOSED

This part here:

conn->send(malloy::buffer(doc), [conn, handler = std::move(handler)]...

Is the issue. See this line:

doc is decontructed and the memory pointed to it (which malloy::buffer wraps but does not own see: asio docs) is deleted almost immediately.

You can wrap it in shared_ptr as a quick and dirty way to keep it around (which is what accept_and_send does iirc). The behaviour is a bit of a gotcha tbh, I'm open to ideas of how to make it less of a sharp corner :p.

from malloy.

Something about shooting yourself in the foot...? :p
The embarrassing thing is that I am/was aware of that and even read that notice when investigating.

This looks like a tricky case to take the edge off. I can currently not think of anything rather than a wrapper which creates the shared_ptr automatically. But then again, the details are so usage specific that it will most likely not be very beneficial of providing an out-of-the-box solution with malloy.
I think implementing application specific handlers similar to how the ws_handlers.cpp in /examples does it is the way to go - but that is application side, not malloy side.

from malloy.