Comments (8)
Yeah I ran into the same issue during testing, its an issue with websocat (issue) you need to pass -E
from malloy.
Found the bug:
malloy/lib/malloy/websocket/stream.hpp
Line 75 in 9eecc9c
from malloy.
I should have time to do it tomorrow. I'll fix it in the log style and we can potentially change it after #40 is resolved
from malloy.
Personally I'd put out a fix for this bug before tackling #40 given that at least on the surface this looks like an easy fix.
from malloy.
There still seems to be an issue so I am reopening this.
When running the malloy-example-server-websocket
example and using websocat -E
the server crashes due to an uncaught exception after sending the 10th message:
C:\Users\joel\Documents\projects\malloy\cmake-build-debug\examples\server\websocket\malloy-example-server-websocket.exe
[2021-07-02 16:37:06.431] [router] [debug] adding websocket endpoint at /
[2021-07-02 16:37:06.432] [router] [debug] adding websocket endpoint at /echo
[2021-07-02 16:37:06.433] [router] [debug] adding websocket endpoint at /timer
[2021-07-02 16:37:06.433] [debug] starting server.
[2021-07-02 16:37:06.434] [debug] starting i/o context.
[2021-07-02 16:40:31.448] [listener] [info] accepting incoming connection from 127.0.0.1:7026
[2021-07-02 16:40:31.449] [http_connection] [debug] launching plain connection.
[2021-07-02 16:40:31.449] [http_connection] [info] upgrading HTTP connection to WS connection.
[2021-07-02 16:40:31.449] [router] [debug] handling WS request: GET /timer
terminate called after throwing an instance of 'boost::wrapexcept<boost::system::system_error>'
what(): End of file
Process finished with exit code 3
from malloy.
#40 is definitely something very vital for the future of this library and needs attention by itself.
I am currently unable to check boost.beast
sourced/API but I do think that there is an overload that takes an error_code
and/or async.
from malloy.
Yes there is, I misunderstood the API there, I though the close_reason
was filled and reported any errors but its meant to actually have a value (not sure if that might be part of the issue with websocat too). So yeah that code needs just plain fixing :p
from malloy.
hehe :p
are you going to submit a patch or should I put this on my ToDo list?
from malloy.
Related Issues (20)
- Expose `run_result_t` publicly HOT 4
- Renaming `controller_run_result` HOT 9
- Usage of start() HOT 9
- Client: SNI hostname on WSS connection
- HTTP: More centralized configuration
- Connection timeout configuration
- Cross-Platform Way to Get Root Certs From Store? HOT 4
- server::listener: provide method for catching binding errors
- HTML form: check for requires fields HOT 2
- HTTP server: Add cache control HOT 1
- HTML form: populate() potentially dangerous HOT 1
- Custom HTTP response generator
- controller i/o threads reservation
- Form parsing should honor Content-Type
- Deprecate HTML namespace
- Generator response types HOT 1
- CMake: Check Windows 11 implementation for get_WIN32_WINNT
- HTTP Client: Allow connection re-use
- Potential issue in session cookie handling
- HTTP: Improve cookie handling
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from malloy.