Git Product home page Git Product logo

Comments (3)

c0deswitch avatar c0deswitch commented on September 23, 2024 1

thanks, it's looking better! i had indicated for the primary Bg to be the darker gray so it got implemented in reverse but it's still better than the light gray it was before.

for best legibility the contrast between the background color and text color should be as high as possible. you'll notice when you switch between light and dark mode on websites or apps like Slack, the text weight typically doesn't change, just the colors do. i do agree that we can make other typographic improvements like adjusting font weights across both - light and dark mode.

from twc-site.

shushugah avatar shushugah commented on September 23, 2024

I believe this is done with #360. But if you have more/further light/dark theme improvements to suggest, let's discuss them here. In general, I noticed with black on white, it's important to have more bold typefaces to make the light colors easier to read on a dark background.

from twc-site.

shushugah avatar shushugah commented on September 23, 2024

Pending tasks

  • Switch grey and grey2 color variables
  • Add make a:hover black in light-theme mode
  • Make a light-theme related css for mobile nav links (see image below)
  • Make event-cards in /events h3 tags instead of h2. See #350 for further event improvements
Screenshot 2024-03-28 at 18 04 43

from twc-site.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.