InvalidOperationException: More calls to EndTask than StartTask. about ambienttasks HOT 3 CLOSED

Perfect, thank you!

I'm sorry! I don't remember seeing a notification for this, but I should have.

from ambienttasks.

@YairHalberstadt This is already fixed in the published MyGet package (commit 82b589a).

We really need to get you off the gist onto the real thing, because this is only one of several significant fixes. I'm going to work on that global handler thing for you.

This is the test that I used to confirm which commit fixed it:

[Test]
[PreventExecutionContextLeaks] // Workaround for https://github.com/nunit/nunit/issues/3283
public static async Task Repro()
{
    AmbientTasks.BeginContext(ex => { });

    AmbientTasks.Add(ExecuteInternal());

    async Task ExecuteInternal()
    {
        var t = Task.FromException(new Exception());
        if (t != null)
        {
            try
            {
                await t.ConfigureAwait(false);
            }
            catch (Exception ex)
            {
                throw;
            }
            finally
            {
            }
        }
    }

    await AmbientTasks.WaitAllAsync();
}

from ambienttasks.

@YairHalberstadt This isn't related to the problem you were having, but the .ConfigureAwait(false) in your sample looks suspicious. Is it the best idea to be setting IsRunning from the thread pool? Please excuse my utter lack of context.

from ambienttasks.