Git Product home page Git Product logo

Comments (17)

saschb2b avatar saschb2b commented on August 13, 2024 2

We need to refactore it with something like https://github.com/moroshko/react-autosuggest

from material-ui-search-bar.

leMaik avatar leMaik commented on August 13, 2024

Unfortunately, AutoComplete was removed in material-ui v1 and thus isn't available anymore in this search bar. 😕

from material-ui-search-bar.

leMaik avatar leMaik commented on August 13, 2024

@saschb2b We might use react-autosuggest to create a new material-ui-legacy-autocomplete component that just behaves like the old AutoComplete. On the other hand, that wouldn't even require using react-autosuggest because it's really simple.

from material-ui-search-bar.

harsha31 avatar harsha31 commented on August 13, 2024

@leMaik Autosuggest is added in material-ui v1. When can we expect autocomplete in searchbar??

from material-ui-search-bar.

leMaik avatar leMaik commented on August 13, 2024

@harsha31 Where? I don't see an AutoComplete component in the v1 branch. There is only a demo on how to implement it using react-autosuggest.

There is no ETA for updating this component. It will be updated when we have time and want to do it, or someone submits a PR. 😉

from material-ui-search-bar.

tifa2UP avatar tifa2UP commented on August 13, 2024

+1.

Had to downgrade to Material-UI v0.18 for this.

from material-ui-search-bar.

afparsons avatar afparsons commented on August 13, 2024

Am I to understand that this package in its current state (even material-ui-search-bar@beta), will absolutely not function with any v1 of material-ui (ex: material-ui 1.0.0-beta.21) ?

from material-ui-search-bar.

leMaik avatar leMaik commented on August 13, 2024

@afparsons It will work, but auto-complete won't work at the moment. We are really looking forward to anyone who wants to implement this. I mean, you obviously need it, so why not take some time and submit a PR? 😃

from material-ui-search-bar.

afparsons avatar afparsons commented on August 13, 2024

@leMaik Alright, time to show my cards. I'm a total noob here. I'd love to submit a PR, but 1) timeliness and 2) quality would both be of concern 😆 . Perhaps in the next two weeks I could take a look, as it seems to not be a priority for you all.

Could I have a 30 second explanation of what auto-complete is and for what it is needed? Or point me to the correct doc... ?

from material-ui-search-bar.

leMaik avatar leMaik commented on August 13, 2024

@afparsons It's a popup that will open below the search bar and show results/suggestions as you type (like your favorite search engine does). Material-UI 0.x had this, here is a demo.

from material-ui-search-bar.

gauravdhiman avatar gauravdhiman commented on August 13, 2024

I see there is a v1.x.x beta tag on repo: https://github.com/TeamWertarbyte/material-ui-search-bar/tree/v1.0.0-beta.4. It should work with material-ui 1.x.x, but could not find that package on NPM. Do you have that release or not yet ?

Please let me know how to install v1.x.x of this repo using NPM or GIT.

from material-ui-search-bar.

saschb2b avatar saschb2b commented on August 13, 2024

@gauravdhiman just use the pre-release channel with the @beta tag
npm install material-ui-search-bar@beta

from material-ui-search-bar.

kaushalyap avatar kaushalyap commented on August 13, 2024

@saschb2b autocomplete not working even with "material-ui-search-bar": "^1.0.0-beta.4",

Also I see following in the console

Warning: React does not recognize the dataSource prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase datasource instead. If you accidentally passed it from a parent component, remove it from the DOM element.

from material-ui-search-bar.

leMaik avatar leMaik commented on August 13, 2024

@KaushalyaPradeep Autocomplete is not implemented. #21 (comment)

from material-ui-search-bar.

lexprom avatar lexprom commented on August 13, 2024

These commands help me:
yarn add @material-ui/core
yarn add @material-ui/icons
Idk my answer is relevant or not. But I hope I helped someone 😄

from material-ui-search-bar.

nithins avatar nithins commented on August 13, 2024

@leMaik Any suggestions for an autocomplete implementation? I thought the Autocomplete component from @material-ui/lab/ could work. But my concern is that it was not part of @material-ui/core/.

from material-ui-search-bar.

leMaik avatar leMaik commented on August 13, 2024

Even if Autocomplete is still in @material-ui/lab, it's probably the way to go, especially since nobody found the time to implement this feature in this library yet: https://material-ui.com/components/autocomplete/#autocomplete

from material-ui-search-bar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.