Comments (4)
Did you use a <meta>
tag to set the viewport size?
<meta name="viewport" content="width=device-width,height=device-height,initial-scale=1,maximum-scale=1">
Edit: Is opening the Safari Inspector a use-case for using this component? 😉 That only appears in development anyway.
from material-ui-fullscreen-dialog.
Did you use a tag to set the viewport size?
Yep, I'm using that exact meta tag.
Edit: Is opening the Safari Inspector a use-case for using this component? 😉 That only appears in development anyway.
It's mainly very odd and distracting to see a full screen element twitch for no good reason. I'm not sure what the benefit is for using vw
instead of %
for the dialog.
from material-ui-fullscreen-dialog.
I'm not sure what the benefit is for using vw instead of % for the dialog.
We want to spawn the entire viewport and not 100% of whatever may be the parent element of our dialog. That's why we have to use vw
instead of 100%
.
We might look into using a portal (as Material-UI does) instead, which would probably fix this issue.
from material-ui-fullscreen-dialog.
I'm not even sure what that means 😛
Anyway, I consider this issue annoying, but low prio. As you stated: That only appears in development anyway.
from material-ui-fullscreen-dialog.
Related Issues (12)
- Unit Test a component having fullscreen-dialog HOT 2
- fullscreen only in mobile screen HOT 2
- Change the close button style HOT 2
- Invalid prop `appBarZDepth` of value `0` supplied to `FullscreenDialog`, expected one of [1,2,3,4,5] HOT 1
- Support for React 16 HOT 1
- Update react-transition-group HOT 1
- Remove close button HOT 1
- Hide body scrollbar when FullScreenDialog is open HOT 1
- Support for v2.x.x react-transition-group HOT 4
- Warning: Failed prop type: Invalid prop `open` of type `function` supplied to `FullscreenDialog`, expected `boolean`. HOT 5
- In material-ui 0.19.0 onTouchTap has been removed.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui-fullscreen-dialog.