Java Formatter triggered by Maven about odftoolkit HOT 5 CLOSED

Someone reported already our problem:
google/google-java-format#413

odfdom\src\main\java\org\odftoolkit\odfdom\pkg\OdfManifestSaxHandler.java
is always the last class being processed before memory exception.

from odftoolkit.

The class OdfManifestSaxHandler.java was all a single comment.
I removed it for 0.9.0 and the format finishes successfully.
Committed all formatted source files for review purpose on the branch.

Would this suit you?

from odftoolkit.

Having a formatting standard for the project sound like a very good idea to me!

Going with the Google Java Style Guide and its tools seems to be a sound choice. There are formatter plugins for all major IDEs (Eclipse and IntelliJ) and also for all major build systems (Maven, Gradle).

from odftoolkit.

It's a bit of a pity to apply a reformatting an such a big codebase, but since there has not been any formatting standard in place up to now, I don't really see a way forward without such an action if we want to introduce this at some point. Doing it has the advantage that in the future history and comparison between branches will be a lot easier and cleaner. But it also has the disadvantage of introducing a lot of noise in the history with this one big commit with lots and lots of changes. Still in favor of using a formatting standard and applying it though.

from odftoolkit.

I fully agree, Sebastian.
As there is a big noise when we "copy over" the fork being done 8 years ago over the 0.9.0 branch, we might even be able to reduce this noise by normalization. Solely the quite last 0.9.0 commit will be very noisy. The copy from 1.0.0 will be with less noise and in the future, we should no longer have this problem.
Okay, I will enable the code normalization and releasing 0.9.0.

from odftoolkit.