Comments in requirements.txt about poetry-add-requirements.txt HOT 5 CLOSED

Hey thanks for filing the issue!

I was aware of this and choose not to support many (or most) of the requirement.txt spec, because

• I did not find an easy way to support them (I think pip itself only offers an easy-to-use installation API, how the file is parse is internal to pip and undocumented. Actually, the pip install command uses internal APIs, I don't think using pip as a lib is recommended).
• I have limited time and only made what was needed for my use cases.

Please feel free to suggest ideas to support this, or open a PR. :)

from poetry-add-requirements.txt.

Please update the tool to v1.1.4 and try again. :)

from poetry-add-requirements.txt.

The new version just ignores the # and therefore treats comments as modules to install.

I would do this:

utils.py

def preprocess_line(line: str) -> str:
    return line.split('#')[0].strip()  # Remove comments and leading/trailing whitespace

from poetry-add-requirements.txt.

@kb- Thanks for the suggestion.

I just tested how pip 23.2.1 treats comments, and I think it ignores comment lines.

Is there any source that supports this?

The new version just ignores the # and therefore treats comments as modules to install

from poetry-add-requirements.txt.

I found the requirements-parser project also just ignore lines that start with '#', see https://sourcegraph.com/github.com/madpah/requirements-parser/-/blob/requirements/parser.py?L62=

I think I'm gonna do just that. :)

Update: implemented in v1.4.0

from poetry-add-requirements.txt.