Static method naming about proposal-array-grouping HOT 11 CLOSED

I think having the name groupBy is important for recognizability (our own ecosystem precedent and from other languages). I don't think there's a clear pattern for naming factory methods.

from proposal-array-grouping.

“fromX” means it’s an X already, and as you said, it’s ungrouped.

from proposal-array-grouping.

TC39 reaffirmed consensus today on the existing groupBy name.

from proposal-array-grouping.

The recognisability of the name does sound very valuable. So like {_,Lodash,Ramda}.groupBy, in this situation the namespace should be seen as a general collection of utilities. And having Array.groupBy doesn't scale as nicely to having various different collection types.

from proposal-array-grouping.

@nickmccurdy This method is the opposite of that - your data is not grouped yet, and you want it to be.

from proposal-array-grouping.

Functions are verbs, so that function could be a "grouper" but wouldn't be "groups", a noun - and fromGrouper sounds like it's a fish :-)

from proposal-array-grouping.

There’s no clear precedent for this - Promise.all and friends produce a Promise, Object.fromEntries and Object.create produce an Object, Array.from produces an Array.

However, Object.keys/values/entries/getOwnPropertyDesceiptor etc operate on an Object.

from proposal-array-grouping.

How about fromGroups? It aligns with existing static methods like Array.fromAsync.

from proposal-array-grouping.

I was thinking of it more from the mathematical perspective, where the callback is a functor mapping an ungrouped collection to a grouped collection. Though if the result is too arbitrary, maybe fromGrouping would be more clear.

from proposal-array-grouping.

@nickmccurdy correct me if I'm wrong, but @ljharb I think what @nickmccurdy is suggesting is that groups is referring to the function that converts from "ungrouped" to "grouped". An expansion of the name could be: getGroupsFromGroups and when you consider the "more clear" version he provided: fromGrouping, this makes even more sense: getGroupsFromGrouping.

from proposal-array-grouping.

I try to avoid putting get in function names as it's usually already obvious. Maybe just groups or grouped could work? Though I'm not sure if they'd have naming collisions.

from proposal-array-grouping.