Git Product home page Git Product logo

Comments (5)

tbolis avatar tbolis commented on May 19, 2024 1

Dear @FerusAndBeyond thank you for your input, I have resolved the issue by adding controlled properties width and height, please check if possible and let me know if it is ok, you can see the example page as well.

from react-sketch.

tbolis avatar tbolis commented on May 19, 2024 1

Cool thx, hope you like the new feature/bug fix

from react-sketch.

FerusAndBeyond avatar FerusAndBeyond commented on May 19, 2024

Changing width and height works perfectly now, thanks! Though unless I did something wrong I noticed 2 issues when height and width are not specified. The height is set to 512 by this statement:

let canvasDivStyle = Object.assign({}, style ? style : {}, width ? {width: width} : {}, height ? {height: height} : {height: 512});

Changing {height:512} to {} removed this issue. Also in the configuration options it says if you leave height/width empty it will scale to parent but that does not seem to be the case for me.

from react-sketch.

tbolis avatar tbolis commented on May 19, 2024

Yes you are right, I have added a reasonable default value for height, I will correct the documentation. The other option would be to leave it blank and will automatically scale to parent height as well, but this would mean that to use the component you would have to be careful to strictly define the parent height.
Besides you can achieve the controlled width and height by supporting it with your own code as a controlled component (with higher order composition etc.)

Hope it helps

from react-sketch.

FerusAndBeyond avatar FerusAndBeyond commented on May 19, 2024

Yes I understand, I was just confused by the documentation.

from react-sketch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.